fix(clippy): resolve some new clippy warnings #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lockfile was updated in #425.
Emilgardis
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some clippy warnings.
#![cfg_attr(test, allow(deprecated))]was added inlib.rsto make editing with rust-analyzer easier. Adding#![allow(deprecated)]for thepubsubmodule doesn't work, because of the test macros (playground).The only remaining warnings are from
too_long_first_doc_paragraphin top-level doc-comments (I don't know how to silence these, as#[allow(...)]doesn't work :/).Other than that,
twitch_typesstill has some warnings. These have been fixed, but there's no release yet (also not really needed, imo).#419 was partly done in #425 (only the edit in
Cargo.tomlwas left), so I did it here. Closes #410.