twitch-rs · bors · Jun 9, 2021 · Jun 9, 2021 · Jun 9, 2021 · Jun 9, 2021
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -91,41 +91,41 @@ jobs:
             target
           key: ${{ runner.os }}-nightly-clippy-cargo-target-${{ hashFiles('**/Cargo.lock') }}
           restore-keys: ${{ runner.os }}-nightly-cargo-target-${{ hashFiles('**/Cargo.lock') }}
-      - name: Run clippy --all-targets --no-default-features -- -D warnings
+      - name: Run clippy --all-targets --no-default-features
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --no-default-features -- -D warnings
-      - name: Run clippy --all-targets --no-default-features --features "helix" -- -D warnings
+          args: --all-targets --no-default-features
+      - name: Run clippy --all-targets --no-default-features --features "helix"
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --no-default-features --features "helix" -- -D warnings
-      - name: Run clippy --all-targets --no-default-features --features "tmi" -- -D warnings
+          args: --all-targets --no-default-features --features "helix"
+      - name: Run clippy --all-targets --no-default-features --features "tmi"
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --no-default-features --features "tmi" -- -D warnings
-      - name: Run clippy --all-targets --no-default-features --features "pubsub" -- -D warnings
+          args: --all-targets --no-default-features --features "tmi"
+      - name: Run clippy --all-targets --no-default-features --features "pubsub"
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --no-default-features --features "pubsub" -- -D warnings
-      - name: Run clippy --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }} trace_unknown_fields" -- -D warnings
+          args: --all-targets --no-default-features --features "pubsub"
+      - name: Run clippy --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }} trace_unknown_fields"
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }} trace_unknown_fields" -- -D warnings
-      - name: Run clippy --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }}" -- -D warnings
+          args: --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }} trace_unknown_fields"
+      - name: Run clippy --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }}"
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }}" -- -D warnings
-      - name: Run clippy --all-targets --all-features -- -D warnings
+          args: --all-targets --features "${{ env.CI_TWITCH_API2_FEATURES }}"
+      - name: Run clippy --all-targets --all-features
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets --all-features -- -D warnings
+          args: --all-targets --all-features
   docs:
     name: Docs
     runs-on: ubuntu-latest

diff --git a/...b/channel/channel_points_custom_reward.rs → ...annel/channel_points_custom_reward/mod.rs b/...b/channel/channel_points_custom_reward.rs → ...annel/channel_points_custom_reward/mod.rs
diff --git a/...hannel_points_custom_reward_redemption.rs → ...el_points_custom_reward_redemption/mod.rs b/...hannel_points_custom_reward_redemption.rs → ...el_points_custom_reward_redemption/mod.rs
diff --git a/src/eventsub/channel/hypetrain.rs → src/eventsub/channel/hypetrain/mod.rs b/src/eventsub/channel/hypetrain.rs → src/eventsub/channel/hypetrain/mod.rs
diff --git a/src/eventsub/channel.rs → src/eventsub/channel/mod.rs b/src/eventsub/channel.rs → src/eventsub/channel/mod.rs
diff --git a/src/eventsub/channel/poll.rs → src/eventsub/channel/poll/mod.rs b/src/eventsub/channel/poll.rs → src/eventsub/channel/poll/mod.rs
diff --git a/src/eventsub/channel/prediction.rs → src/eventsub/channel/prediction/mod.rs b/src/eventsub/channel/prediction.rs → src/eventsub/channel/prediction/mod.rs
diff --git a/src/eventsub/channel/subscription.rs → src/eventsub/channel/subscription/mod.rs b/src/eventsub/channel/subscription.rs → src/eventsub/channel/subscription/mod.rs
diff --git a/src/eventsub/stream.rs → src/eventsub/stream/mod.rs b/src/eventsub/stream.rs → src/eventsub/stream/mod.rs
diff --git a/src/eventsub/user.rs → src/eventsub/user/mod.rs b/src/eventsub/user.rs → src/eventsub/user/mod.rs
diff --git a/src/helix/bits.rs → src/helix/bits/mod.rs b/src/helix/bits.rs → src/helix/bits/mod.rs
diff --git a/src/helix/channels.rs → src/helix/channels/mod.rs b/src/helix/channels.rs → src/helix/channels/mod.rs
diff --git a/src/helix/chat.rs → src/helix/chat/mod.rs b/src/helix/chat.rs → src/helix/chat/mod.rs
diff --git a/src/helix/clips.rs → src/helix/clips/mod.rs b/src/helix/clips.rs → src/helix/clips/mod.rs
diff --git a/src/helix/eventsub.rs → src/helix/eventsub/mod.rs b/src/helix/eventsub.rs → src/helix/eventsub/mod.rs
diff --git a/src/helix/games.rs → src/helix/games/mod.rs b/src/helix/games.rs → src/helix/games/mod.rs
diff --git a/src/helix/hypetrain.rs → src/helix/hypetrain/mod.rs b/src/helix/hypetrain.rs → src/helix/hypetrain/mod.rs
diff --git a/src/helix/mod.rs b/src/helix/mod.rs
@@ -378,14 +378,14 @@ pub trait RequestPost: Request {
     where
         Self: Sized,
     {
-        let text = std::str::from_utf8(&response.body()).map_err(|e| {
+        let text = std::str::from_utf8(response.body()).map_err(|e| {
             HelixRequestPostError::Utf8Error(response.body().clone(), e, uri.clone())
         })?;
         if let Ok(HelixRequestError {
             error,
             status,
             message,
-        }) = parse_json::<HelixRequestError>(&text, false)
+        }) = parse_json::<HelixRequestError>(text, false)
         {
             return Err(HelixRequestPostError::Error {
                 error,
@@ -408,7 +408,7 @@ pub trait RequestPost: Request {
     where
         Self: Sized,
     {
-        let response: InnerResponse<<Self as Request>::Response> = parse_json(&response, true)
+        let response: InnerResponse<<Self as Request>::Response> = parse_json(response, true)
             .map_err(|e| {
                 HelixRequestPostError::DeserializeError(
                     response.to_string(),
@@ -471,14 +471,14 @@ pub trait RequestPatch: Request {
     where
         Self: Sized,
     {
-        let text = std::str::from_utf8(&response.body()).map_err(|e| {
+        let text = std::str::from_utf8(response.body()).map_err(|e| {
             HelixRequestPatchError::Utf8Error(response.body().clone(), e, uri.clone())
         })?;
         if let Ok(HelixRequestError {
             error,
             status,
             message,
-        }) = parse_json::<HelixRequestError>(&text, false)
+        }) = parse_json::<HelixRequestError>(text, false)
         {
             return Err(HelixRequestPatchError::Error {
                 error,
@@ -540,14 +540,14 @@ pub trait RequestDelete: Request {
     where
         Self: Sized,
     {
-        let text = std::str::from_utf8(&response.body()).map_err(|e| {
+        let text = std::str::from_utf8(response.body()).map_err(|e| {
             HelixRequestDeleteError::Utf8Error(response.body().clone(), e, uri.clone())
         })?;
         if let Ok(HelixRequestError {
             error,
             status,
             message,
-        }) = parse_json::<HelixRequestError>(&text, false)
+        }) = parse_json::<HelixRequestError>(text, false)
         {
             return Err(HelixRequestDeleteError::Error {
                 error,
@@ -616,14 +616,14 @@ pub trait RequestPut: Request {
     where
         Self: Sized,
     {
-        let text = std::str::from_utf8(&response.body()).map_err(|e| {
+        let text = std::str::from_utf8(response.body()).map_err(|e| {
             HelixRequestPutError::Utf8Error(response.body().clone(), e, uri.clone())
         })?;
         if let Ok(HelixRequestError {
             error,
             status,
             message,
-        }) = parse_json::<HelixRequestError>(&text, false)
+        }) = parse_json::<HelixRequestError>(text, false)
         {
             return Err(HelixRequestPutError::Error {
                 error,
@@ -685,15 +685,15 @@ pub trait RequestGet: Request {
     where
         Self: Sized,
     {
-        let text = std::str::from_utf8(&response.body()).map_err(|e| {
+        let text = std::str::from_utf8(response.body()).map_err(|e| {
             HelixRequestGetError::Utf8Error(response.body().clone(), e, uri.clone())
         })?;
         //eprintln!("\n\nmessage is ------------ {} ------------", text);
         if let Ok(HelixRequestError {
             error,
             status,
             message,
-        }) = parse_json::<HelixRequestError>(&text, false)
+        }) = parse_json::<HelixRequestError>(text, false)
         {
             return Err(HelixRequestGetError::Error {
                 error,

diff --git a/src/helix/moderation/check_automod_status.rs b/src/helix/moderation/check_automod_status.rs
@@ -105,7 +105,7 @@ impl helix::HelixRequestBody for Vec<CheckAutoModStatusBody> {
             data: &'a Vec<CheckAutoModStatusBody>,
         }
 
-        serde_json::to_vec(&InnerBody { data: &self }).map_err(Into::into)
+        serde_json::to_vec(&InnerBody { data: self }).map_err(Into::into)
     }
 }
 

diff --git a/src/helix/moderation.rs → src/helix/moderation/mod.rs b/src/helix/moderation.rs → src/helix/moderation/mod.rs
diff --git a/src/helix/points/create_custom_rewards.rs b/src/helix/points/create_custom_rewards.rs
@@ -143,7 +143,7 @@ impl RequestPost for CreateCustomRewardRequest {
         Self: Sized,
     {
         let response: helix::InnerResponse<Vec<Self::Response>> =
-            helix::parse_json(&response_str, true).map_err(|e| {
+            helix::parse_json(response_str, true).map_err(|e| {
                 helix::HelixRequestPostError::DeserializeError(
                     response_str.to_string(),
                     e,

diff --git a/src/helix/points.rs → src/helix/points/mod.rs b/src/helix/points.rs → src/helix/points/mod.rs
diff --git a/src/helix/polls/create_poll.rs b/src/helix/polls/create_poll.rs
@@ -150,7 +150,7 @@ impl RequestPost for CreatePollRequest {
         Self: Sized,
     {
         let response: helix::InnerResponse<Vec<Self::Response>> =
-            helix::parse_json(&response_str, true).map_err(|e| {
+            helix::parse_json(response_str, true).map_err(|e| {
                 helix::HelixRequestPostError::DeserializeError(
                     response_str.to_string(),
                     e,

diff --git a/src/helix/polls.rs → src/helix/polls/mod.rs b/src/helix/polls.rs → src/helix/polls/mod.rs
diff --git a/src/helix/predictions/create_prediction.rs b/src/helix/predictions/create_prediction.rs
@@ -142,7 +142,7 @@ impl RequestPost for CreatePredictionRequest {
         Self: Sized,
     {
         let response: helix::InnerResponse<Vec<Self::Response>> =
-            helix::parse_json(&response_str, true).map_err(|e| {
+            helix::parse_json(response_str, true).map_err(|e| {
                 helix::HelixRequestPostError::DeserializeError(
                     response_str.to_string(),
                     e,

diff --git a/src/helix/predictions.rs → src/helix/predictions/mod.rs b/src/helix/predictions.rs → src/helix/predictions/mod.rs
diff --git a/src/helix/search.rs → src/helix/search/mod.rs b/src/helix/search.rs → src/helix/search/mod.rs
diff --git a/src/helix/search/search_categories.rs b/src/helix/search/search_categories.rs
@@ -84,7 +84,7 @@ impl RequestGet for SearchCategoriesRequest {
         Self: Sized,
     {
         let response: helix::InnerResponse<Option<Self::Response>> =
-            helix::parse_json(&response, true).map_err(|e| {
+            helix::parse_json(response, true).map_err(|e| {
                 helix::HelixRequestGetError::DeserializeError(
                     response.to_string(),
                     e,

diff --git a/src/helix/ser.rs b/src/helix/ser.rs
@@ -674,7 +674,7 @@ impl<'input, 'output> ser::Serializer for PairSerializer<'input, 'output> {
         _variant_index: u32,
         variant: &'static str,
     ) -> Result<Self::Ok, Self::Error> {
-        self.urlencoder.append_pair(self.key, &variant);
+        self.urlencoder.append_pair(self.key, variant);
         Ok(self.urlencoder)
     }
 

diff --git a/src/helix/streams.rs → src/helix/streams/mod.rs b/src/helix/streams.rs → src/helix/streams/mod.rs
diff --git a/src/helix/subscriptions/check_user_subscription.rs b/src/helix/subscriptions/check_user_subscription.rs
@@ -95,7 +95,7 @@ impl RequestGet for CheckUserSubscriptionRequest {
         Self: Sized,
     {
         let inner_response: helix::InnerResponse<Vec<_>> =
-            helix::parse_json(&text, true).map_err(|e| {
+            helix::parse_json(text, true).map_err(|e| {
                 helix::HelixRequestGetError::DeserializeError(
                     text.to_string(),
                     e,

diff --git a/src/helix/subscriptions.rs → src/helix/subscriptions/mod.rs b/src/helix/subscriptions.rs → src/helix/subscriptions/mod.rs
diff --git a/src/helix/tags.rs → src/helix/tags/mod.rs b/src/helix/tags.rs → src/helix/tags/mod.rs
diff --git a/src/helix/teams.rs → src/helix/teams/mod.rs b/src/helix/teams.rs → src/helix/teams/mod.rs
diff --git a/src/helix/users.rs → src/helix/users/mod.rs b/src/helix/users.rs → src/helix/users/mod.rs
diff --git a/src/helix/videos.rs → src/helix/videos/mod.rs b/src/helix/videos.rs → src/helix/videos/mod.rs
diff --git a/src/helix/webhooks/hub.rs b/src/helix/webhooks/hub.rs
@@ -183,14 +183,14 @@ impl<T: Topic> RequestPost for WebhookHubRequest<T> {
     where
         Self: Sized,
     {
-        let text = std::str::from_utf8(&response.body()).map_err(|e| {
+        let text = std::str::from_utf8(response.body()).map_err(|e| {
             helix::HelixRequestPostError::Utf8Error(response.body().clone(), e, uri.clone())
         })?;
         if let Ok(helix::HelixRequestError {
             error,
             status,
             message,
-        }) = helix::parse_json::<helix::HelixRequestError>(&text, false)
+        }) = helix::parse_json::<helix::HelixRequestError>(text, false)
         {
             return Err(helix::HelixRequestPostError::Error {
                 error,

diff --git a/src/helix/webhooks.rs → src/helix/webhooks/mod.rs b/src/helix/webhooks.rs → src/helix/webhooks/mod.rs
diff --git a/src/lib.rs b/src/lib.rs
@@ -3,7 +3,6 @@
 #![cfg_attr(nightly, deny(rustdoc::broken_intra_doc_links))]
 #![cfg_attr(nightly, feature(doc_cfg))]
 #![doc(html_root_url = "https://docs.rs/twitch_api2/0.5.0")]
-#![cfg_attr(all(nightly, doctest), feature(external_doc))]
 //! [![github]](https://github.com/emilgardis/twitch_api2)&ensp;[![crates-io]](https://crates.io/crates/twitch_api2)&ensp;[![docs-rs-big]](https://docs.rs/twitch_api2/0.5.0/twitch_api2)
 //!
 //! [github]: https://img.shields.io/badge/github-emilgardis/twitch__api2-8da0cb?style=for-the-badge&labelColor=555555&logo=github"
@@ -90,8 +89,12 @@
 //! | <span class="module-item stab portability" style="display: inline; border-radius: 3px; padding: 2px; font-size: 80%; line-height: 1.2;"><code>deny_unknown_fields</code></span> | Adds `#[serde(deny_unknown_fields)]` on all applicable structs/enums. Please consider using this and filing an issue or PR when a new field has been added to the endpoint but not added to this library. |
 //!
 
-#[doc(include = "../README.md")]
-#[cfg(all(doctest, feature = "all"))]
+// FIXME: This is a hack to prevent early pass failing on
+// `arbitrary expressions in key-value attributes are unstable` on stable rust pre 1.54.
+// Remove when MSRV 1.54 (or when  hits stable)
+// https://github.com/rust-lang/rust/issues/82768
+/// Doc test for README
+#[cfg_attr(all(doctest, nightly, feature = "all"), cfg_attr(all(doctest, nightly, feature = "all"), doc = include_str!("../README.md")))]
 pub struct ReadmeDoctests;
 
 pub mod types;
-Original file line number
+Diff line change
@@ Expand Up @@
                 data: &'a Vec<CheckAutoModStatusBody>,
             }
-            serde_json::to_vec(&InnerBody { data: &self }).map_err(Into::into)
+            serde_json::to_vec(&InnerBody { data: self }).map_err(Into::into)
         }
     }
@@ Expand Down @@