Working python3 version#112
Draft
perkinslr wants to merge 157 commits into
Draft
Conversation
Add support for FilePath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my ancient port (from about 2016) to python3.5+. It needs some work to reconcile the changes upstream (and to clean up some of the dirty hacks I did to get it functional), but at least some parts of it should help other efforts to get this to python3 (and it may be a better starting point than the last 2.7 release).
Note that it does not use
six, as I had no need to run on python2 after the migration. Instead, I used 2to3 (from python3.4), which broke things terribly, and then spent far too much time sorting out what that stupid script broke.