-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix server pagination #171
base: master
Are you sure you want to change the base?
Conversation
if not self.connected: | ||
raise LDAPServerConnectionLostException() | ||
msg = pureldap.LDAPMessage(op, id=id) | ||
msg = pureldap.LDAPMessage(op, controls=controls, id=id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
controls=None is handled in pureldap so no need to handle it here. so just pass it.
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 93.35% 90.64% -2.71%
==========================================
Files 72 72
Lines 9914 9898 -16
Branches 972 974 +2
==========================================
- Hits 9255 8972 -283
- Misses 537 802 +265
- Partials 122 124 +2
Continue to review full report at Codecov.
|
This also solved my issue where I was seeing this exception on my client app:
|
See #163 for details.
Don't merge without further investigation!
It's the example how i solved this for my usecase.