Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VBLOCKS-3670] build: Update the release process to version the documentation for major versions #90

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

luisrivas
Copy link
Collaborator

Pull Request Details

JIRA link(s):

Description

  • Update the release process to version the documentation for major versions

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

@@ -48,6 +48,7 @@
"@types/mocha": "^8.2.1",
"@types/node": "^14.14.31",
"@types/sinon": "^9.0.10",
"@types/sinonjs__fake-timers": "^8.1.5",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build step since I had this error while building:

> @twilio/video-processors@2.2.1-dev build:version
> node ./scripts/version.js

error TS2688: Cannot find type definition file for 'sinonjs__fake-timers'.
  The file is in the program because:
    Entry point for implicit type library 'sinonjs__fake-timers'


Found 1 error.

ERROR: "build:es5" exited with 2.

Copy link
Collaborator

@charliesantos charliesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating docs for every major version, can we create docs for all versions instead? It will make this simpler. Also, make the root folder as the latest docs. In other words, keep the current script as is since it's already saving the docs in the root. We just need to add a few lines in the script that creates a separate folder for that version. The directory structure would look something like the following:

Screenshot 2024-12-18 at 9 49 53 AM

@luisrivas
Copy link
Collaborator Author

luisrivas commented Dec 18, 2024

Instead of creating docs for every major version, can we create docs for all versions instead? It will make this simpler. Also, make the root folder as the latest docs. In other words, keep the current script as is since it's already saving the docs in the root. We just need to add a few lines in the script that creates a separate folder for that version. The directory structure would look something like the following:

Screenshot 2024-12-18 at 9 49 53 AM

I just updated the script to create docs for all versions instead. Regarding the root folder, if I understand it correctly, any new publication would be latest and could be either v2 or v3. What do you think @charliesantos ?

@charliesantos
Copy link
Collaborator

Instead of creating docs for every major version, can we create docs for all versions instead? It will make this simpler. Also, make the root folder as the latest docs. In other words, keep the current script as is since it's already saving the docs in the root. We just need to add a few lines in the script that creates a separate folder for that version. The directory structure would look something like the following:
Screenshot 2024-12-18 at 9 49 53 AM

I just updated the script to create docs for all versions instead. Regarding the root folder, if I understand it correctly, any new publication would be latest and could be either v2 or v3. What do you think @charliesantos ?

This is a good point @luisrivas . I would think we don't want to overwrite the latest if it's v3, and if the new release is a v2, as an example. I think we can address that later if you want. We usually never had to backport a feature. If the customer requires something to be fixed, we usually ask them to update to the latest. Wdyt? Does this sound reasonable?

@luisrivas
Copy link
Collaborator Author

Instead of creating docs for every major version, can we create docs for all versions instead? It will make this simpler. Also, make the root folder as the latest docs. In other words, keep the current script as is since it's already saving the docs in the root. We just need to add a few lines in the script that creates a separate folder for that version. The directory structure would look something like the following:
Screenshot 2024-12-18 at 9 49 53 AM

I just updated the script to create docs for all versions instead. Regarding the root folder, if I understand it correctly, any new publication would be latest and could be either v2 or v3. What do you think @charliesantos ?

This is a good point @luisrivas . I would think we don't want to overwrite the latest if it's v3, and if the new release is a v2, as an example. I think we can address that later if you want. We usually never had to backport a feature. If the customer requires something to be fixed, we usually ask them to update to the latest. Wdyt? Does this sound reasonable?

It sounds good to me! This solution is good enough and simple that we could revisit it in the future if we need to adjust anything. Thanks for the feedback.

@luisrivas luisrivas merged commit 2857cf1 into master Jan 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants