Skip to content

chore(side-panel): fix margin flashing bug #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkrantz merged 1 commit into from
Aug 21, 2025
Merged

chore(side-panel): fix margin flashing bug #4378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/red-waves-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@twilio-paste/side-panel": patch
"@twilio-paste/core": patch
---

[Side Panel] Fix bug where rendering side panel closed would flash a right margin while breakpointindex was undefined.
2 changes: 1 addition & 1 deletion packages/paste-core/components/side-panel/src/SidePanelPushContentWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const SidePanelPushContentWrapper = React.forwardRef<HTMLDivElement, Side
{...safelySpreadBoxProps(props)}
ref={ref}
// when using side panels in responsive layouts, we don't want any left margin in small screen, or initial SSR render situations. So basically never apply it in those situations
style={breakpointIndex === undefined || breakpointIndex === 0 ? undefined : styles}
style={breakpointIndex === 0 ? undefined : styles}
marginRight={["space0", theme.sizes.size40]}
minWidth="size0"
element={element}
Expand Down
Loading