Skip to content

check for return type #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tacman wants to merge 3 commits into from
Closed

check for return type #4721

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d57bd0e
check for return type
tacman Dec 3, 2025
10a1dab
Update extra/twig-extra-bundle/TwigExtraBundle.php
tacman Dec 3, 2025
9aec2b6
Update extra/twig-extra-bundle/TwigExtraBundle.php
tacman Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions extra/twig-extra-bundle/TwigExtraBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Twig\Extra\TwigExtraBundle\DependencyInjection\Compiler\MissingExtensionSuggestorPass;

if (!method_exists(ContainerBuilder::class, 'getAutoconfiguredAttributes')) {
$refMethod = new \ReflectionMethod(\Symfony\Component\HttpKernel\Bundle\Bundle::class, 'build');
Copy link
Member

@stof stof Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed as this is unused.


if ($refMethod->hasReturnType()) {
class TwigExtraBundle extends Bundle
{
public function build(ContainerBuilder $container): void
{
parent::build($container);

Copy link
Contributor

@xabbuh xabbuh Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted

$container->addCompilerPass(new MissingExtensionSuggestorPass());
}
}
Expand All @@ -32,8 +33,8 @@ class TwigExtraBundle extends Bundle
public function build(ContainerBuilder $container)
{
parent::build($container);

Copy link
Contributor

@xabbuh xabbuh Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted

$container->addCompilerPass(new MissingExtensionSuggestorPass());
}
}
}

Copy link
Contributor

@xabbuh xabbuh Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted