-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fixed Align all field-level permissions #14695 #15046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdtawhid012
wants to merge
2
commits into
twentyhq:main
Choose a base branch
from
mdtawhid012:field-level-permissions-#14695
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−516
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Empty file modified
0
packages/twenty-apps/hello-world/.yarn/releases/yarn-4.9.2.cjs
100755 → 100644
Empty file.
Binary file removed
BIN
-6.46 MB
packages/twenty-cli/src/constants/base-application-project/.yarn/install-state.gz
Binary file not shown.
Empty file modified
0
packages/twenty-cli/src/constants/base-application-project/.yarn/releases/yarn-4.9.2.cjs
100755 → 100644
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 11 additions & 11 deletions
22
...ront/src/modules/ui/layout/selectable-list/states/isSelectedItemIdComponentFamilyState.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
import { SelectableListComponentInstanceContext } from '@/ui/layout/selectable-list/states/contexts/SelectableListComponentInstanceContext'; | ||
import { createComponentFamilyState } from '@/ui/utilities/state/component-state/utils/createComponentFamilyState'; | ||
export const isSelectedItemIdComponentFamilyState = createComponentFamilyState< | ||
boolean, | ||
string | ||
>({ | ||
key: 'isSelectedItemIdComponentFamilyState', | ||
defaultValue: false, | ||
componentInstanceContext: SelectableListComponentInstanceContext, | ||
}); | ||
import { SelectableListComponentInstanceContext } from '@/ui/layout/selectable-list/states/contexts/SelectableListComponentInstanceContext'; | ||
import { createComponentFamilyState } from '@/ui/utilities/state/component-state/utils/createComponentFamilyState'; | ||
|
||
export const isSelectedItemIdComponentFamilyState = createComponentFamilyState< | ||
boolean, | ||
string | ||
>({ | ||
key: 'isSelectedItemIdComponentFamilyState', | ||
defaultValue: false, | ||
componentInstanceContext: SelectableListComponentInstanceContext, | ||
}); |
20 changes: 10 additions & 10 deletions
20
...nty-front/src/modules/ui/layout/selectable-list/states/selectableItemIdsComponentState.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import { SelectableListComponentInstanceContext } from '@/ui/layout/selectable-list/states/contexts/SelectableListComponentInstanceContext'; | ||
import { createComponentState } from '@/ui/utilities/state/component-state/utils/createComponentState'; | ||
export const selectableItemIdsComponentState = createComponentState<string[][]>( | ||
{ | ||
key: 'selectableItemIdsComponentState', | ||
defaultValue: [[]], | ||
componentInstanceContext: SelectableListComponentInstanceContext, | ||
}, | ||
); | ||
import { SelectableListComponentInstanceContext } from '@/ui/layout/selectable-list/states/contexts/SelectableListComponentInstanceContext'; | ||
import { createComponentState } from '@/ui/utilities/state/component-state/utils/createComponentState'; | ||
|
||
export const selectableItemIdsComponentState = createComponentState<string[][]>( | ||
{ | ||
key: 'selectableItemIdsComponentState', | ||
defaultValue: [[]], | ||
componentInstanceContext: SelectableListComponentInstanceContext, | ||
}, | ||
); |
20 changes: 10 additions & 10 deletions
20
...twenty-front/src/modules/ui/layout/selectable-list/states/selectedItemIdComponentState.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import { SelectableListComponentInstanceContext } from '@/ui/layout/selectable-list/states/contexts/SelectableListComponentInstanceContext'; | ||
import { createComponentState } from '@/ui/utilities/state/component-state/utils/createComponentState'; | ||
|
||
export const selectedItemIdComponentState = createComponentState<string | null>( | ||
{ | ||
key: 'selectedItemIdComponentState', | ||
defaultValue: null, | ||
componentInstanceContext: SelectableListComponentInstanceContext, | ||
}, | ||
); | ||
import { SelectableListComponentInstanceContext } from '@/ui/layout/selectable-list/states/contexts/SelectableListComponentInstanceContext'; | ||
import { createComponentState } from '@/ui/utilities/state/component-state/utils/createComponentState'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Consider updating to use createComponentStateV2 for consistency with the documented approach in the codebase Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/twenty-front/src/modules/ui/layout/selectable-list/states/selectedItemIdComponentState.ts
Line: 2:2
Comment:
**style:** Consider updating to use createComponentStateV2 for consistency with the documented approach in the codebase
How can I resolve this? If you propose a fix, please make it concise. |
||
|
||
export const selectedItemIdComponentState = createComponentState<string | null>( | ||
{ | ||
key: 'selectedItemIdComponentState', | ||
defaultValue: null, | ||
componentInstanceContext: SelectableListComponentInstanceContext, | ||
}, | ||
); |
Empty file.
Empty file.
Empty file.
Empty file modified
0
...er/src/engine/core-modules/serverless/drivers/layers/engine/.yarn/releases/yarn-4.9.2.cjs
100755 → 100644
Empty file.
167 changes: 0 additions & 167 deletions
167
...se-event-trigger/workspace-migration-v2-database-event-trigger-actions-builder.service.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consistent with other occurrences - formatting and potential logic issues need to be addressed.
Prompt To Fix With AI