Skip to content

Align all field-level UI fix #14709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Align all field-level UI fix #14709

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0a079b
fixed UI
ketanMehtaa Sep 24, 2025
d6a32a0
remove unused
ketanMehtaa Sep 24, 2025
5c6c085
added height again
ketanMehtaa Sep 24, 2025
5b698e7
Merge branch 'main' into fix/allFieldHeader
lucasbordeau Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions ...s/components/SettingsRolePermissionsObjectLevelObjectFieldPermissionTableAllHeaderRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { useRestrictReadOnAllFieldsOfObject } from '@/settings/roles/role-permis
import { useRestrictUpdateOnAllFieldsOfObject } from '@/settings/roles/role-permissions/object-level-permissions/field-permissions/hooks/useRestrictUpdateOnAllFieldsOfObject';
import { OverridableCheckbox } from '@/settings/roles/role-permissions/object-level-permissions/object-form/components/OverridableCheckbox';
import { settingsDraftRoleFamilyState } from '@/settings/roles/states/settingsDraftRoleFamilyState';
import { TableCell } from '@/ui/layout/table/components/TableCell';
import styled from '@emotion/styled';
import { useLingui } from '@lingui/react/macro';
import { useRecoilState } from 'recoil';
Expand All @@ -18,18 +19,9 @@ const StyledSectionHeader = styled.div`
border-bottom: 1px solid ${({ theme }) => theme.border.color.light};
display: grid;
grid-template-columns: ${FIELD_LEVEL_PERMISSION_TABLE_GRID_TEMPLATE_COLUMNS};

height: ${({ theme }) => theme.spacing(6)};

padding-left: ${({ theme }) => theme.spacing(2)};
`;

const StyledCheckboxContainer = styled.div`
display: flex;
justify-content: flex-end;
padding-right: ${({ theme }) => theme.spacing(1)};
`;

export const SettingsRolePermissionsObjectLevelObjectFieldPermissionTableAllHeaderRow =
({
roleId,
Expand Down Expand Up @@ -105,24 +97,24 @@ export const SettingsRolePermissionsObjectLevelObjectFieldPermissionTableAllHead
<>
{shouldShowEmptyTableHeader && <div />}
{shouldShowSeeTableHeader && (
<StyledCheckboxContainer>
<TableCell>
<OverridableCheckbox
disabled={false}
checked={true}
onChange={handleReadAllChange}
type={hasAnyRestrictionOnRead ? 'override' : 'default'}
/>
</StyledCheckboxContainer>
</TableCell>
)}
{shouldShowUpdateTableHeader && (
<StyledCheckboxContainer>
<TableCell>
<OverridableCheckbox
disabled={false}
checked={true}
onChange={handleUpdateAllChange}
type={hasAnyRestrictionOnUpdate ? 'override' : 'default'}
/>
</StyledCheckboxContainer>
</TableCell>
)}
</>
</StyledSectionHeader>
Expand Down
Loading