pin versions #6
Merged
pin versions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneem
reviewed
Nov 6, 2023
separate-memory-transfer/README.md
Outdated
| > wasm-bindgen ../target/wasm32-unknown-unknown/release/separate_memory_transfer.wasm --target=no-modules --out-dir=pkg | ||
| > python ../server.py | ||
| ```sh | ||
| cargo install --version 0.2.81 wasm-bindgen-cli --force |
There was a problem hiding this comment.
Suggested change
| cargo install --version 0.2.81 wasm-bindgen-cli --force | |
| cargo install --version 0.2.81 wasm-bindgen-cli --force # if you aren't getting it from the nix flake |
(For people using nix, the flake.nix/flake.lock files already provide the correct version of wasm-bindgen-cli)
separate-memory/README.md
Outdated
| > wasm-bindgen ../target/wasm32-unknown-unknown/release/separate_memory.wasm --target=no-modules --out-dir=pkg | ||
| > python ../server.py | ||
| ```sh | ||
| cargo install --version 0.2.81 wasm-bindgen-cli --force |
shared-memory/README.md
Outdated
| > wasm-bindgen ../target/wasm32-unknown-unknown/release/shared_memory.wasm --target=no-modules --out-dir=pkg | ||
| > python ../server.py | ||
| ```sh | ||
| cargo install --version 0.2.81 wasm-bindgen-cli --force |
|
Rubbing my two braincells together and clicking a few more links led me to rust-lang/rust#113152 so I deleted all the Cargo.lock files and recreated the workspace lockfile - now the latest nightly works. |
|
Ah, I originally started with three separate workspaces and then when I merged it into one I guess I forgot that there should only be the top-level lockfile... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
Here's a starting point :)
I think nightly is only needed for shared-memory. I went with
nightly-2023-06-15because the more recent ones broke for reasons that are beyond me so I blindly went with this answer.