fix(status): improve battery health percentage accuracy#991
Merged
Conversation
manuelguido
changed the title
Var block alignment was off, causing gofmt -l to flag the file.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL go/incorrect-integer-conversion flagged the float64-to-int cast on line 237. The literal "value < 100000" guard wasn't enough for the analyzer to prove the conversion was safe. Switching to ioRegValueForKey + strconv.Atoi yields an int directly, no cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inaccurate battery health percentages in
mo statusby preferring the normalizedAppleSmartBatteryhealth capacity fromioregwhen available.On newer macOS versions,
system_profilercan report a lower maximum capacity than the value shown in System Settings. Mole now usesAppleSmartBatteryas the primary source for the health percentage, while keepingsystem_profileras a fallback for health condition and older systems.Fixes
Closes #ISSUE_NUMBER
Changes
AppleSmartBatteryMaxCapacityvalues for battery health percentage.system_profilerJSON/text parsing as fallback.97%vs100%mismatch.Testing
git diff --check -- cmd/status/metrics_battery.go cmd/status/metrics_battery_test.goNot run:
go test ./cmd/status, because the local shell did not havegoorgofmtavailable.