Skip to content

@tus/gcs-store: correctly pass content type #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2025
Merged

@tus/gcs-store: correctly pass content type #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea4da45
@tus/gcs-store: correctly pass content type
Murderlon Jan 20, 2025
6271375
Create proud-terms-swim.md
Murderlon Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/proud-terms-swim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tus/gcs-store": patch
---

Correctly pass the content type from upload.metadata to GCS.
7 changes: 5 additions & 2 deletions packages/gcs-store/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {Bucket} from '@google-cloud/storage'
import type {Bucket, CreateWriteStreamOptions} from '@google-cloud/storage'
import stream from 'node:stream'
import type http from 'node:http'
import debug from 'debug'
Expand Down Expand Up @@ -35,14 +35,17 @@ export class GCSStore extends DataStore {

file.storage = {type: 'gcs', path: file.id, bucket: this.bucket.name}

const options = {
const options: CreateWriteStreamOptions = {
metadata: {
metadata: {
tus_version: TUS_RESUMABLE,
...this.#stringifyUploadKeys(file),
},
},
}
if (file.metadata?.contentType) {
options.contentType = file.metadata.contentType
}
const fake_stream = new stream.PassThrough()
fake_stream.end()
fake_stream
Expand Down
Loading