Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tursodatabase/turso-driver-laravel#7 #8

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ineersa
Copy link
Contributor

@ineersa ineersa commented Jul 8, 2024

added inTransaction method for compatibility with PDO

@darkterminal
Copy link
Collaborator

darkterminal commented Jul 9, 2024

Sorry, I am bit confused here. About issues #7, #9, #10, and #11.

I've Laravel example also here And it's work.

Please provide a clear context for your case in each issue made. Since this is confusing me once again, I am working and trying to integrate Tenancy for Laravel and before that, I also used commands like:

php artisan migrate
php artisan migrate:fresh
php artisan migrate:rollback

It's working fine in Local, Remote, and Embedded Replica connection. Btw, still you have put a lot of time into this, thank you. However, I still need clear context. And once again, the libSQL Extension I created is not built with the PDO engine, it's a pure libSQL driver that wraps the libSQL binary from Turso written in Rust.

If you have a more effective method to wrap libSQL for Laravel as a custom driver, I would love to discuss it and try to implement it to be used for In-memory, Local, Remote and Embedded replica connections.

@ineersa
Copy link
Contributor Author

ineersa commented Jul 9, 2024

Hi, those issues are things which are not working in driver, since I'm building an app I thought it would be good to make issues and PR's where i can make them, like in this case.
This PR fixes transaction rollback, which is not working in current version.
I've tried to describe problems in issues, also https://github.com/ineersa/turso-driver-laravel/tree/dev-branch dev branch because I need a lot of fixes, if you have questions regarding issues I'm free to discuss them.

It's working fine in Local, Remote, and Embedded Replica connection

For me sadly it's not like that, I'm having issues using it, some of which are really hard to fix and need intervention into extension (like there is no SQL errors), so maybe it would be better to fix this package issues and test things out before integrating it into some other packages?

@darkterminal
Copy link
Collaborator

I will update the main branch, because I made changes while trying to integrate Tenancy for Laravel. About broken things happen, it's true.

After I push some changes in the main branch, maybe you can adjust your connection. I've been working on it for almost 2 weeks.

@ineersa
Copy link
Contributor Author

ineersa commented Jul 9, 2024

I will update the main branch, because I made changes while trying to integrate Tenancy for Laravel. About broken things happen, it's true.

After I push some changes in the main branch, maybe you can adjust your connection. I've been working on it for almost 2 weeks.

For this it won't be a problem this changes are quite small, but for #5 it might be, let's see what conflicts will be.

@darkterminal
Copy link
Collaborator

Yes, we'll see it...

@darkterminal darkterminal merged commit 4ccd962 into tursodatabase:main Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants