Skip to content

Prevent holding lock to context between sync interval ticks #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

levydsa
Copy link
Contributor

@levydsa levydsa commented May 26, 2025

Fixes #2076.

@levydsa levydsa requested a review from PThorpe92 May 27, 2025 17:50
@levydsa levydsa changed the title Yield back to executor in push/pull offline Prevent holding lock to sync context between sync interval ticks May 29, 2025
@levydsa levydsa changed the title Prevent holding lock to sync context between sync interval ticks Prevent holding lock to context between sync interval ticks May 29, 2025
@levydsa levydsa requested a review from PThorpe92 May 29, 2025 13:50
Copy link

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@penberg penberg added this pull request to the merge queue May 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@penberg penberg added this pull request to the merge queue May 29, 2025
Merged via the queue into tursodatabase:main with commit e0ce549 May 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded replicas (and offline sync) databases are slow if you set sync_interval
3 participants