Skip to content

Added how-to find mode value in SArray #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Tabular Data Transformation
* [Parse a datetime column into its components (year, month, etc.)](split_datetime_column.py)
* [Convert a column of datetime strings into UNIX timestamps](convert_column_to_timestamp.py)
* [Expand an SFrame column of type list/dict into multiple columns](sframe_unpack.py)
* [Find the mode of an SArray](sarray_mode.py)

Graph Data Transformation
---------------------------
Expand Down
69 changes: 69 additions & 0 deletions sarray_mode.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import graphlab as gl

def mode_sa(sa, single_mode=True):
"""Return a mode of sa, or all modes if there are several.

single_mode: whether to return a single mode or an SArray of all modes (default: True)."""

if len(sa) == 0:
raise ValueError("Can't find mode(s) in empty SArray")

sf = gl.SFrame({"value": sa})
sf2 = sf.groupby("value", {"count": gl.aggregate.COUNT()})
max_count_index = sf2["count"].argmax()

if single_mode:
return sf2[max_count_index]["value"]

else:
max_count = sf2[max_count_index]["count"]
return sf2[sf2["count"] == max_count]["value"]


# Create an SArray with two modes (most-common elements: 2 and 3)
sa = gl.SArray([1, 2, 2, 3, 3])

# Find one of the modes
single_mode = mode_sa(sa) # returns 2

# Find all modes
all_modes = mode_sa(sa, single_mode=False)
# Returns
# dtype: int
# Rows: 2
# [2, 3]


# A faster (albeit maybe less accurate) way to find the mode value is using sa.sketch_summary().frequent_items() .
# There are two caveats to this approach:
# 1. won't work for very low-frequency mode values, and
# 2. won't necessarily give the correct result if there are multiple likely candidates.

def sketch_mode_sa(sa, single_mode=True):
"""Fast (albeit less accurate) way to find the mode value(s) of SArray sa.

single_mode: whether to return a single mode or an SArray of all modes (default: True)."""

if len(sa) == 0:
raise ValueError("Can't find mode(s) in empty SArray")

frequent_items_sketch = sa.sketch_summary().frequent_items()
modes_sketch = [k for (k, v) in frequent_items_sketch.iteritems()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be slow if the list of frequent items is long (and there is not really an upper bound to how long it can be). Here it calls itervalues for each item of the dict and max on that. For perf this should be refactored to use a single call to max(itervalues) and a comparison to that stored value.

if v == max(frequent_items_sketch.itervalues())]
return modes_sketch[0] if single_mode else modes_sketch

sketch_mode_sa(sa) # returns 2
sketch_mode_sa(sa, single_mode=False) # returns [2, 3]


# Both approaches should handle empty SArrays.
# The implementations above will simply raise a ValueError if `sa` is empty.
try:
mode_sa(gl.SArray([]))
except ValueError:
pass

try:
sketch_mode_sa(gl.SArray([]))
except ValueError:
pass