Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #107 and should be merged after it.
Closes #108
Add Basic Authentication support to net_http_request table
This PR adds a
user_credentialscolumn that acceptsusername:passwordformat and automatically encodes it as a Basic Auth header, similar to curl's--userflag.Changes
user_credentialscolumn to table definitionUserCredentialsfield to request structsTesting
Tested against httpbin.org's basic-auth endpoint:
Result:
Also tested with invalid credentials:
Result:
Also tested with combining
insecure = trueon an internal API server.