Add hardhat #6
Open
Add hardhat #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo:
|
:D |
julien51
reviewed
Feb 9, 2025
Comment on lines
+12
to
+25
| subtask(TASK_COMPILE_SOLIDITY).setAction(async (_, { config }, runSuper) => { | ||
| const superRes = await runSuper(); | ||
|
|
||
| try { | ||
| await writeFile( | ||
| join(config.paths.artifacts, "package.json"), | ||
| '{ "type": "commonjs" }', | ||
| ); | ||
| } catch (error) { | ||
| console.error("Error writing package.json: ", error); | ||
| } | ||
|
|
||
| return superRes; | ||
| }); |
There was a problem hiding this comment.
probably a nit but I would move that to a tasks folder
julien51
reviewed
Feb 9, 2025
| @@ -0,0 +1,37 @@ | |||
| { | |||
| "name": "solidity-cbor", | |||
| "private": true, | |||
There was a problem hiding this comment.
This will likely need to go away when you're ready to publish?
|
i think i'm going to convert this repository to a workspace, with hardhat tools at the root only, so the hardhat/foundry dual config is less awkward and special-cased. |
|
also concerned that esm config creates problems for consumption. workspacing it should allow that to be tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add hardhat, and a basic consuming fixture.
esm mode because i'm insane.
cc @julien51
haven't set up publishing yet, try it out with
pnpm pack.