fix: prevent returning the previous route data on route transition #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valerioageno
force-pushed
the
return-null-on-loading
branch
from
63d8664 to
868f3de
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
marcalexiei
requested changes
Mar 14, 2025
This comment was marked as resolved.
This comment was marked as resolved.
marcalexiei
reviewed
Mar 14, 2025
| </div> | ||
| )) as RouteComponent | ||
| RootComponent.preload = vi.fn() | ||
| RootComponent.displayName = routeType | ||
| return RootComponent | ||
| } | ||
|
|
||
| function createLeafRouteComponent(routeType: string): RouteComponent { |
There was a problem hiding this comment.
From @jacobhq review comment #646 (review)
Looks good, although I don't understand why we need the createLeafRouteComponent function, would you mind explaining?
There was a problem hiding this comment.
I think it makes sense having them separate, since passing data creates a weird HTML output that is weird dealing with.
marcalexiei
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes #626
Overview