Skip to content

Feat/add registry support #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuannvm wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feat/add registry support #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f45128
chore(config): Add server configuration JSON for MCP Trino
tuannvm Sep 9, 2025
6a83e66
ci(package): Add MCPB bundle creation and upload steps
tuannvm Sep 9, 2025
c4f59c1
chore: Update bundle filename references and manifest.json fields
tuannvm Sep 9, 2025
eb55af2
fix(manifest): Update Linux and Windows entry points to correct keys
tuannvm Sep 9, 2025
4038ecf
chore(server.json): Update package URL and placeholder SHA256
tuannvm Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions .dxtignore
View file
Open in desktop

This file was deleted.

21 changes: 20 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
TAG_PREFIX: v
VERBOSE: true

- name: Run GoReleaser
- name: Validate GoReleaser config and release
uses: goreleaser/goreleaser-action@v6
if: steps.tag.outputs.new_tag != ''
with:
Expand All @@ -56,6 +56,24 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Create MCPB bundle
if: steps.tag.outputs.new_tag != ''
run: |
GORELEASER_VERSION=${{ steps.tag.outputs.new_tag }} make pack-mcpb-from-dist
ls -la ${{ github.event.repository.name }}.mcpb || (echo "MCPB bundle not found" && exit 1)

- name: Upload MCPB bundle to release
if: steps.tag.outputs.new_tag != ''
run: |
if [ -f "${{ github.event.repository.name }}.mcpb" ]; then
gh release upload ${{ steps.tag.outputs.new_tag }} ${{ github.event.repository.name }}.mcpb --clobber
else
echo "Error: MCPB bundle not found for upload"
exit 1
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Docker meta
id: meta
if: steps.tag.outputs.new_tag != ''
Expand Down Expand Up @@ -87,6 +105,7 @@ jobs:
platforms: 'arm64,amd64,arm'

- name: downcase REPO
if: steps.tag.outputs.new_tag != ''
run: |
echo "IMAGE_NAME=${GITHUB_REPOSITORY,,}" >> $GITHUB_ENV

Expand Down
7 changes: 4 additions & 3 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ make docker-compose-down # Stop Docker Compose
make run-docker # Build and run Docker image locally

# Release and packaging
make release-snapshot # Create snapshot release with GoReleaser
make build-dxt # Build platform-specific binaries for DXT
make pack-dxt # Package DXT extension
make release-snapshot # Create snapshot release with GoReleaser
make build-platform-binaries # Build platform-specific binaries for MCPB
make build-mcpb # Build MCPB bundle
make pack-mcpb-from-dist # Create MCPB from GoReleaser binaries

# Testing individual components
go test ./internal/config # Test configuration package
Expand Down
76 changes: 64 additions & 12 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.PHONY: build build-dxt pack-dxt test clean run-dev release-snapshot run-docker run docker-compose-up docker-compose-down lint docker-test
.PHONY: build build-platform-binaries build-mcpb pack-mcpb-from-dist test clean run-dev release-snapshot run-docker run docker-compose-up docker-compose-down lint docker-test

# Variables
BINARY_NAME=mcp-trino
BINARY_NAME ?= $(shell basename $(shell git remote get-url origin) .git | sed 's/.*\///')
VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo "dev")
BUILD_DIR=bin

Expand All @@ -10,22 +10,71 @@ build:
mkdir -p $(BUILD_DIR)
go build -ldflags "-X main.Version=$(VERSION)" -o $(BUILD_DIR)/$(BINARY_NAME) ./cmd

# Build all platform-specific binaries for DXT packaging
build-dxt:
# Build all platform-specific binaries for MCPB packaging
build-platform-binaries:
mkdir -p server
@echo "Building platform-specific binaries for DXT..."
@echo "Building platform-specific binaries for MCPB..."
GOOS=darwin GOARCH=arm64 go build -ldflags "-X main.Version=$(VERSION)" -o server/$(BINARY_NAME)-darwin-arm64 ./cmd
GOOS=darwin GOARCH=amd64 go build -ldflags "-X main.Version=$(VERSION)" -o server/$(BINARY_NAME)-darwin-amd64 ./cmd
GOOS=linux GOARCH=amd64 go build -ldflags "-X main.Version=$(VERSION)" -o server/$(BINARY_NAME)-linux-amd64 ./cmd
GOOS=windows GOARCH=amd64 go build -ldflags "-X main.Version=$(VERSION)" -o server/$(BINARY_NAME)-windows-amd64.exe ./cmd
chmod +x server/$(BINARY_NAME)-*
@echo "All platform binaries built in server/ directory"

# Package DXT extension
pack-dxt: build-dxt
@echo "Packaging DXT extension..."
dxt pack
@echo "DXT package created: $(BINARY_NAME).dxt"
# Build MCPB bundle
build-mcpb: build-platform-binaries
@echo "Creating MCPB bundle..."
@if [ ! -f "manifest.json" ]; then \
echo "Error: manifest.json not found"; \
exit 1; \
fi
mkdir -p mcpb-bundle/server
cp server/* mcpb-bundle/server/
# Update version and name in manifest.json to match build version and binary name
sed -e 's/"version": ".*"/"version": "$(VERSION)"/' -e 's/"name": "$(BINARY_NAME)"/"name": "$(BINARY_NAME)"/' manifest.json > mcpb-bundle/manifest.json
cd mcpb-bundle && zip -r ../$(BINARY_NAME).mcpb . && cd ..
rm -rf mcpb-bundle
@echo "MCPB bundle created: $(BINARY_NAME).mcpb"

Comment on lines +24 to +38
Copy link

@coderabbitai coderabbitai bot Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Sed-based JSON patching is brittle; name replacement is a no-op.

The sed for "name" won’t match (it looks for literal "$(BINARY_NAME)"), and generic s/".*"/ risks touching unintended fields. Use jq and strip leading v from tags.

-	# Update version and name in manifest.json to match build version and binary name
-	sed -e 's/"version": ".*"/"version": "$(VERSION)"/' -e 's/"name": "$(BINARY_NAME)"/"name": "$(BINARY_NAME)"/' manifest.json > mcpb-bundle/manifest.json
+	# Update version and name via jq; strip leading 'v' if present
+	ver_no_v=$$(printf '%s' "$(VERSION)" | sed 's/^v//'); \
+	jq --arg v "$$ver_no_v" --arg n "$(BINARY_NAME)" \
+	   '.version=$$v | .name=$$n' manifest.json > mcpb-bundle/manifest.json
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Build MCPB bundle
build-mcpb: build-platform-binaries
@echo "Creating MCPB bundle..."
@if [ ! -f "manifest.json" ]; then \
echo "Error: manifest.json not found"; \
exit 1; \
fi
mkdir -p mcpb-bundle/server
cp server/* mcpb-bundle/server/
# Update version and name in manifest.json to match build version and binary name
sed -e 's/"version": ".*"/"version": "$(VERSION)"/' -e 's/"name": "$(BINARY_NAME)"/"name": "$(BINARY_NAME)"/' manifest.json > mcpb-bundle/manifest.json
cd mcpb-bundle && zip -r ../$(BINARY_NAME).mcpb . && cd ..
rm -rf mcpb-bundle
@echo "MCPB bundle created: $(BINARY_NAME).mcpb"
# Build MCPB bundle
build-mcpb: build-platform-binaries
@echo "Creating MCPB bundle..."
@if [ ! -f "manifest.json" ]; then \
echo "Error: manifest.json not found"; \
exit 1; \
fi
mkdir -p mcpb-bundle/server
cp server/* mcpb-bundle/server/
# Update version and name via jq; strip leading 'v' if present
ver_no_v=$$(printf '%s' "$(VERSION)" | sed 's/^v//'); \
jq --arg v "$$ver_no_v" --arg n "$(BINARY_NAME)" \
'.version=$$v | .name=$$n' manifest.json > mcpb-bundle/manifest.json
cd mcpb-bundle && zip -r ../$(BINARY_NAME).mcpb . && cd ..
rm -rf mcpb-bundle
@echo "MCPB bundle created: $(BINARY_NAME).mcpb"
🤖 Prompt for AI Agents 
In Makefile around lines 24 to 38, the sed-based JSON edits are brittle and the
name replacement is a no-op because it looks for the literal "$(BINARY_NAME)";
replace the sed step with a jq-based rewrite that safely updates the
manifest.json "name" and "version" fields: set .name to the shell-expanded
$(BINARY_NAME) and set .version to $(VERSION) after stripping a leading "v" if
present (do the strip in shell before passing to jq or use jq sub to remove a
leading "v"), write the modified JSON into mcpb-bundle/manifest.json and
continue bundling as before.

# Pack MCPB from GoReleaser dist/ folder
pack-mcpb-from-dist:
@echo "Creating MCPB bundle from GoReleaser binaries..."
mkdir -p mcpb-bundle/server
@# Copy specific platform binaries with explicit names
@found_count=0; \
for platform in "linux_amd64" "darwin_amd64" "darwin_arm64" "windows_amd64"; do \
found=$$(find dist -path "*_$${platform}_*" -name "$(BINARY_NAME)*" -type f | head -1); \
if [ -n "$$found" ]; then \
case "$$platform" in \
"linux_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-linux-amd64" ;; \
"darwin_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-darwin-amd64" ;; \
"darwin_arm64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-darwin-arm64" ;; \
"windows_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-windows-amd64.exe" ;; \
esac; \
echo "Copied $$found -> $(BINARY_NAME)-$$platform"; \
found_count=$$((found_count + 1)); \
else \
echo "Warning: No binary found for $$platform"; \
fi; \
Comment on lines +45 to +58
Copy link

@coderabbitai coderabbitai bot Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Robust artifact selection; avoid copying archives.

Current find may grab .tar.gz/.zip instead of binaries. Filter out archives and ensure executability after copy.

-		found=$$(find dist -path "*_$${platform}_*" -name "$(BINARY_NAME)*" -type f | head -1); \
+		found=$$(find dist -path "*_$${platform}_*" -type f \
+			\( -name "$(BINARY_NAME)" -o -name "$(BINARY_NAME).exe" -o -name "$(BINARY_NAME)-*" \) \
+			! -name "*.tar.gz" ! -name "*.tgz" ! -name "*.zip" | head -1); \
@@
-				"linux_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-linux-amd64" ;; \
+				"linux_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-linux-amd64" ;; \
@@
 			esac; \
+			chmod +x mcpb-bundle/server/$(BINARY_NAME)-* 2>/dev/null || true; \
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
for platform in "linux_amd64" "darwin_amd64" "darwin_arm64" "windows_amd64"; do \
found=$$(find dist -path "*_$${platform}_*" -name "$(BINARY_NAME)*" -type f | head -1); \
if [ -n "$$found" ]; then \
case "$$platform" in \
"linux_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-linux-amd64" ;; \
"darwin_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-darwin-amd64" ;; \
"darwin_arm64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-darwin-arm64" ;; \
"windows_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-windows-amd64.exe" ;; \
esac; \
echo "Copied $$found -> $(BINARY_NAME)-$$platform"; \
found_count=$$((found_count + 1)); \
else \
echo "Warning: No binary found for $$platform"; \
fi; \
for platform in "linux_amd64" "darwin_amd64" "darwin_arm64" "windows_amd64"; do \
found=$$(find dist -path "*_$${platform}_*" -type f \
\( -name "$(BINARY_NAME)" -o -name "$(BINARY_NAME).exe" -o -name "$(BINARY_NAME)-*" \) \
! -name "*.tar.gz" ! -name "*.tgz" ! -name "*.zip" | head -1); \
if [ -n "$$found" ]; then \
case "$$platform" in \
"linux_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-linux-amd64" ;; \
"darwin_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-darwin-amd64" ;; \
"darwin_arm64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-darwin-arm64" ;; \
"windows_amd64") cp "$$found" "mcpb-bundle/server/$(BINARY_NAME)-windows-amd64.exe" ;; \
esac; \
chmod +x mcpb-bundle/server/$(BINARY_NAME)-* 2>/dev/null || true; \
echo "Copied $$found -> $(BINARY_NAME)-$$platform"; \
found_count=$$((found_count + 1)); \
else \
echo "Warning: No binary found for $$platform"; \
fi; \
🤖 Prompt for AI Agents 
In Makefile around lines 45 to 58, the find invocation can match archive files
(e.g. .tar.gz, .zip) instead of actual binaries; update the find filter to
exclude common archive extensions and prefer executable files (use find
predicates like -not -name '*.tar.gz' -not -name '*.zip' and/or -executable or
-perm to ensure executables are selected), keep the same platform case mapping
for destination names, and after copying set executable permission (chmod +x)
for non-Windows targets so copied artifacts are runnable; preserve the warning
when none found and increment found_count as before.

done; \
if [ $$found_count -eq 0 ]; then \
echo "Error: No binaries found in dist/ directory"; \
exit 1; \
fi
@if [ ! -f "manifest.json" ]; then \
echo "Error: manifest.json not found"; \
rm -rf mcpb-bundle; \
exit 1; \
fi
# Update version and name in manifest.json to match GoReleaser version and binary name
@if [ -n "$(GORELEASER_VERSION)" ]; then \
sed -e 's/"version": ".*"/"version": "$(GORELEASER_VERSION)"/' -e 's/"name": "$(BINARY_NAME)"/"name": "$(BINARY_NAME)"/' manifest.json > mcpb-bundle/manifest.json; \
else \
sed -e 's/"version": ".*"/"version": "$(VERSION)"/' -e 's/"name": "$(BINARY_NAME)"/"name": "$(BINARY_NAME)"/' manifest.json > mcpb-bundle/manifest.json; \
fi
cd mcpb-bundle && zip -r ../$(BINARY_NAME).mcpb . && cd ..
rm -rf mcpb-bundle
@echo "MCPB bundle created: $(BINARY_NAME).mcpb"

# Run tests
test:
Expand All @@ -35,7 +84,9 @@ test:
clean:
rm -rf $(BUILD_DIR)
rm -rf server
rm -f $(BINARY_NAME).dxt $(BINARY_NAME)-*.dxt
rm -rf mcpb-bundle
rm -rf dist
rm -f $(BINARY_NAME).mcpb

# Run the application in development mode
run-dev:
Expand All @@ -44,9 +95,10 @@ run-dev:
# Create a release snapshot using GoReleaser
release-snapshot:
goreleaser release --snapshot --clean
make pack-mcpb-from-dist

# Run the application using the built binary
run:
run: build
./$(BUILD_DIR)/$(BINARY_NAME)

# Build and run Docker image
Expand Down
37 changes: 13 additions & 24 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"dxt_version": "0.1",
"manifest_version": "0.1",
"name": "mcp-trino",
"display_name": "Trino MCP Server",
"version": "1.5.0",
"version": "2.2.1",
"description": "A high-performance Model Context Protocol (MCP) server that enables AI assistants to interact with Trino's distributed SQL query engine through standardized MCP tools",
"long_description": "This MCP server provides comprehensive access to Trino's distributed SQL query engine with features including:\n\n- Execute SQL queries with security restrictions\n- Discover catalogs, schemas, and tables\n- Retrieve table structure and column information\n- SSL/TLS support for secure connections\n- Configurable query timeouts\n- Cross-platform binaries for macOS, Windows, and Linux\n\nCompatible with Claude Desktop, Cursor, Windsurf, ChatWise, and any MCP-compatible clients.",
"author": {
Expand All @@ -17,15 +17,18 @@
"support": "https://github.com/tuannvm/mcp-trino/issues",
"license": "MIT",
"compatibility": {
"claude_desktop": ">=0.10.0",
"claude_desktop": ">=0.12.129",
"platforms": ["darwin", "win32", "linux"]
},
"server": {
"type": "binary",
"entry_point": "server/mcp-trino-darwin-arm64",
"entry_point": {
"darwin-arm64": "server/mcp-trino-darwin-arm64",
"darwin-amd64": "server/mcp-trino-darwin-amd64",
"linux-amd64": "server/mcp-trino-linux-amd64",
"win32-amd64": "server/mcp-trino-windows-amd64.exe"
},
"mcp_config": {
"command": "sh",
"args": ["-c", "chmod +x \"${__dirname}/server/mcp-trino-darwin-arm64\" && \"${__dirname}/server/mcp-trino-darwin-arm64\""],
"env": {
"TRINO_HOST": "${user_config.trino_host}",
"TRINO_PORT": "${user_config.trino_port}",
Expand All @@ -36,15 +39,6 @@
"TRINO_SSL_INSECURE": "${user_config.trino_ssl_insecure}",
"TRINO_ALLOW_WRITE_QUERIES": "${user_config.trino_allow_write_queries}",
"TRINO_QUERY_TIMEOUT": "${user_config.trino_query_timeout}"
},
"platforms": {
"win32": {
"command": "${__dirname}/server/mcp-trino-windows-amd64.exe"
},
"linux": {
"command": "sh",
"args": ["-c", "chmod +x \"${__dirname}/server/mcp-trino-linux-amd64\" && \"${__dirname}/server/mcp-trino-linux-amd64\""]
}
}
}
},
Expand Down Expand Up @@ -134,15 +128,10 @@
{
"name": "get_table_schema",
"description": "Retrieve table structure and column information"
},
{
"name": "explain_query",
"description": "Analyze query execution plans without running expensive queries"
}
],
"features": [
"STDIO and HTTP transport support",
"Server-Sent Events (SSE) for web clients",
"SQL injection protection with read-only enforcement",
"Configurable query timeouts",
"SSL/TLS support for secure connections",
"Multi-platform binary support",
"Docker container support"
]
}
52 changes: 52 additions & 0 deletions server.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"$schema": "https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json",
"name": "io.github.tuannvm/mcp-trino",
"description": "MCP server for Trino distributed SQL query engine access",
"status": "active",
"repository": {
"url": "https://github.com/tuannvm/mcp-trino",
"source": "github"
},
"version": "2.2.1",
"packages": [
{
"registry_type": "mcpb",
"identifier": "https://github.com/tuannvm/mcp-trino/releases/download/v2.2.1/mcp-trino.mcpb",
"version": "2.2.1",
"file_sha256": "PLACEHOLDER_SHA256",
"transport": {
"type": "stdio"
},
"environment_variables": [
{
"description": "Trino server hostname",
"is_required": true,
"format": "string",
"is_secret": false,
"name": "TRINO_HOST"
},
{
"description": "Trino server port",
"is_required": false,
"format": "string",
"is_secret": false,
"name": "TRINO_PORT"
},
{
"description": "Trino username",
"is_required": true,
"format": "string",
"is_secret": false,
"name": "TRINO_USER"
},
{
"description": "Trino password",
"is_required": false,
"format": "string",
"is_secret": true,
"name": "TRINO_PASSWORD"
}
]
}
]
}
Loading