Repository navigation
chore(deps): refresh fast-uri development locks - #1247
HengYangDS wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 2
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
|
Thanks @HengYangDS for following through on your report and sketch. Your two lockfile changes match our independently prepared #1246 byte-for-byte against the same The scoped local install, audit, core and generated checks in #1246 are additional evidence on identical lockfile contents, at its recorded Node/npm versions; they do not replace your current-head CI. Before final review, please personally review the submitted changes and explanation and confirm the contributor checkbox (or reply with the same confirmation). No rerun of the matching local checks is requested. This is not approval or authorization to merge. |
|
CI is blocked by the README showcase receipt, rather than the lock update. The failed job reports The test, builder, GIF, receipt and all three source artifacts are byte-identical to the PR base |
|
#1304 fixed the WebM browser startup failure. Rebased onto The two-lockfile patch is unchanged from the qualified version, and both manifests are unchanged. This is ready for review. Earlier README and sandbox failures remain documented above; the sandbox restoration request is resolved. |
3a03f99 to
469d0ca
Compare
469d0ca to
fa7e352
Compare
Problem and value
Closes #1126. Scope was agreed in #1126 (comment).
The root and renderer development locks retain fast-uri 3.1.8 and 3.1.7, which have published advisories. This updates both to 3.1.9 within the existing override. Only the version, registry URL and integrity change; manifests and other dependencies are unchanged. The distributed Skill excludes these development dependencies.
AI assistance and accountability
Codex (GPT-6; exact model variant unavailable) prepared the two-lock update, rebase and checks under @HengYangDS's direction. The problem was found during dependency inspection.
Stability impact
Development dependency maintenance. No renderer, Viewer or schema behavior changes. Existing CLI and generated-output checks cover compatibility; no new test is needed for a lock-only refresh.
Tests run
Current head
fa7e352fis rebased ontodevc6b74b5f. The manifests and both lockfiles are byte-identical to the previous qualified head. The new head passes all 19 core tests, generated checks and a byte-identical canonical ZIP rebuild on official Node 22.23.3. Current CI passed all 19 jobs, with two deployments skipped by scope, includingwebm-decodeandwebm-artifact, which failed on the previous head before #1304 changed how the WebM gate starts Chrome.Earlier dependency checks on
3a03f99b, based ondev63c9263e, used official Node 22.23.3 and npm 10.9.9:npm ci --ignore-scripts --no-audit --no-fundand the renderer equivalent).npm audit --jsonresults report zero vulnerabilities.npm test: 19 passed, no failures or skips.npm run test:generated: passed; generated files remain unchanged.git diff --check: passed.These are local macOS arm64 checks. Personal review is confirmed. The earlier CI failure from README showcase drift remains recorded at #1247 (comment). That source dependency is now included, and final-head CI has passed; maintainer review remains.