Repository navigation
fix(explainer): leave the preset badges out of the hosted Viewer #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
8e3a033
6a8069a
63fbe7d
495831e
2e7ea55
4a18e68
7f36b46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Hosted Viewer badges (#1195, #1196) | ||
|
|
||
| An editorial explainer should retain its preset and Viewer tools without the standalone field-note and plate badges. The standalone Viewer remains unchanged. | ||
|
|
||
| Comparison base: `63c9263e84bd3993cab8e09b3d69888857858635`. | ||
| Candidate source: `bd5b9f321056c79d7adc27540592bc72afd3d81c`. | ||
| Both use the same [explainer input](explainer.json), Chrome, Node.js 22.23.3, 1440 × 900 viewport, light theme, editorial preset, and open “Read cache” step. Captures wait 800 ms after the editorial preset has applied. | ||
|
|
||
| | Before | After | | ||
| | -------------------------------------------------- | ------------------------------------------------ | | ||
| |  |  | | ||
|
|
||
| The [receipt](evidence.json) records input and image hashes, browser observations, and the pixel comparison. Exactly 3,271 of 1,296,000 pixels change, within the two badge regions. The title, toolbar, diagram, legend, and controls are pixel-identical. The browser reports both badges as `block` on the base and `none` on the candidate; the preset remains `editorial`. | ||
|
|
||
| The Agent inspected both captures. @HengYangDS personally reviewed the submitted changes and explanation and confirmed understanding on 6 November 2026. Maintainer scope agreement was recorded on 6 November in [#1195](https://github.com/tt-a1i/archify/issues/1195#issuecomment-6690778603). The capture receipt retains the review state observed when the images were taken. This fixed-input presentation comparison makes no claim about Agent generation speed or first-draft quality. | ||
|
|
||
| The related behavioral regression can be run from the repository root with Chrome available: | ||
|
|
||
| ```sh | ||
| ARCHIFY_CHROME="/path/to/chrome" npm run test:browser -- test/explainer-browser.test.mjs | ||
| ``` | ||
|
|
||
| Source checks and CI from candidate `bd5b9f32` remain applicable because this evidence-only addition does not change runtime, test, generated-artifact, or build inputs. Required CI at the publication head remains separate. | ||
|
|
||
| [Signal-flow and blueprint pairs](presets/README.md) complete the additional hosted-preset evidence requested by the maintainer. The expanded browser test covers all four preset choices; its new validation is recorded with those pairs. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "capturedAt": "2026-11-06T12:00:11.609Z", | ||
| "route": "Fixed-input hosted Viewer presentation comparison", | ||
| "base": "63c9263e84bd3993cab8e09b3d69888857858635", | ||
| "candidateSource": "bd5b9f321056c79d7adc27540592bc72afd3d81c", | ||
| "conditions": { | ||
| "viewport": [1440, 900], | ||
| "theme": "light", | ||
| "preset": "editorial", | ||
| "openStep": "Read cache", | ||
| "readyWaitMs": 800, | ||
| "node": "22.23.3", | ||
| "chrome": "Google Chrome on macOS", | ||
| "sameInput": true | ||
| }, | ||
| "files": { | ||
| "explainer.json": "10b97b676dc26670acf6c977987e7364d4d0034cbfa09e643fe2b4c28a7bed09", | ||
| "after.1440x900.light.png": "cc6d81deb76c7d68947314e88514c7a1dfd9b3f1a756ba2746b9be4543148889", | ||
| "before.1440x900.light.png": "e712500329e11be1cca3da8a1cf186465e60ebeb5d7eaeac723e85b239040a57" | ||
| }, | ||
| "browser": { | ||
| "baseBadgeDisplay": ["block", "block"], | ||
| "candidateBadgeDisplay": ["none", "none"], | ||
| "consoleErrors": [], | ||
| "nativeProfilesRemoved": true | ||
| }, | ||
| "pixelComparison": { | ||
| "size": [1440, 900], | ||
| "changedPixels": 3271, | ||
| "bounds": [340, 93, 1300, 165], | ||
| "inputEqual": true | ||
| }, | ||
| "humanReview": "Pending accountable contributor confirmation", | ||
| "scopeAgreement": "Pending maintainer decision in issue #1195" | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.