-
Notifications
You must be signed in to change notification settings - Fork 79
Clarify non-span-normalised pca #3359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9299,23 +9299,28 @@ def pca( | |||||
| eigenvectors of the genetic relatedness matrix, which are obtained by a | ||||||
| randomized singular value decomposition (rSVD) algorithm. | ||||||
|
|
||||||
| Concretely, if :math:`M` is the matrix of genetic relatedness values, with | ||||||
| :math:`M_{ij}` the output of | ||||||
| :meth:`genetic_relatedness <.TreeSequence.genetic_relatedness>` | ||||||
| between sample :math:`i` and sample :math:`j`, then by default this returns | ||||||
| the top ``num_components`` eigenvectors of :math:`M`, so that | ||||||
| Concretely, take :math:`M` as the matrix of non-span-normalised | ||||||
| branch-based genetic relatedness values, for instance obtained by | ||||||
| setting :math:`M_{ij}` to be the :meth:`~.TreeSequence.genetic_relatedness` | ||||||
| between sample :math:`i` and sample :math:`j` with ``mode="branch"``, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| ``proportion=False`` and ``span_normalise=False``. Then by default this | ||||||
| returns the top ``num_components`` eigenvectors of :math:`M`, so that | ||||||
hyanwong marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| ``output.factors[i,k]`` is the position of sample `i` on the `k` th PC. | ||||||
| If ``samples`` or ``individuals`` are provided, then this does the same thing, | ||||||
| except with :math:`M_{ij}` either the relatedness between ``samples[i]`` | ||||||
| and ``samples[j]`` or the nodes of ``individuals[i]`` and ``individuals[j]``, | ||||||
| respectively. | ||||||
| If ``samples`` or ``individuals`` are provided, then this does the same | ||||||
| thing, except with :math:`M_{ij}` either the relatedness between | ||||||
| ``samples[i]`` and ``samples[j]`` or the average relatedness between the | ||||||
| nodes of ``individuals[i]`` and ``individuals[j]``, respectively. | ||||||
| Factors are normalized to have L2 norm 1, i.e., | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| ``output.factors[:,k] ** 2).sum() == 1)`` for any ``k``. | ||||||
|
|
||||||
| The parameters ``centre`` and ``mode`` are passed to | ||||||
| :meth:`genetic_relatedness <.TreeSequence.genetic_relatedness>`; | ||||||
| if ``windows`` are provided then PCA is carried out separately in each window. | ||||||
| If ``time_windows`` is provided, then genetic relatedness is measured using only | ||||||
| ancestral material within the given time window (see | ||||||
| :meth:`decapitate <.TreeSequence.decapitate>` for how this is defined). | ||||||
| :meth:`~.TreeSequence.genetic_relatedness`: the default ``centre=True`` results | ||||||
| in factors whose elements sum to zero; ``mode`` currently only supports the | ||||||
| ``"branch"`` setting. If ``windows`` are provided then PCA is carried out | ||||||
| separately in each genomic window. If ``time_windows`` is provided, then genetic | ||||||
| relatedness is measured using only ancestral material within the given time | ||||||
| window (see :meth:`decapitate <.TreeSequence.decapitate>` for how this is | ||||||
| defined). | ||||||
|
|
||||||
| So that the method scales to large tree sequences, the underlying method | ||||||
| relies on a randomized SVD algorithm, using | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.