Reverted: reject invalid high-density routing output - #1982
Reverted: reject invalid high-density routing output#1982ShiboSoftwareDev wants to merge 14 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Comment Everything after Use Any PR whose title contains |
|
/benchmark-long --dataset 18 --sample-numbers 2,6,13,14,15 --concurrency 1 --sample-timeout 2000s |
18 ResultsPrevious main runDataset: srj18
Previous main run details
Dataset: srj18
PR run details
Workflow: View run |
|
/benchmark-long --dataset 18 --sample-numbers 2,6,13,14,15 --concurrency 1 --sample-timeout 2000s |
18 ResultsPrevious main runDataset: srj18
Previous main run details
Dataset: srj18
PR run details
Workflow: View run |
|
/benchmark-long --dataset 18 --sample-numbers 2,6,13,14,15 --concurrency 1 --sample-timeout 2000s |
18 ResultsPrevious main runDataset: srj18
Previous main run details
Dataset: srj18
PR run details
Workflow: View run |
|
/benchmark-long --dataset 24 --sample-numbers 2,5,7 --concurrency 1 --sample-timeout 2000s |
24 ResultsPrevious main runNo previous main run is available for Dataset: srj24
PR run details
Workflow: View run |
|
/usf |
📸 Update Snapshots (focused)
Focused test files:
Source failure run: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/31216454289 Changed snapshots:
Environment: benchmark runner ( 🔗 Workflow: View run |
|
/benchmark --dataset 18 --sample-numbers 2,6,13,14,15 --concurrency 1 --sample-timeout 2000s |
18 ResultsPrevious main runDataset: srj18
Previous main run details
Dataset: srj18
PR run details
Workflow: View run |
|
/benchmark --dataset 24 --sample-numbers 2,5,7 --concurrency 1 --sample-timeout 2000s |
24 ResultsPrevious main runNo previous main run is available for Dataset: srj24
PR run details
Workflow: View run |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
Status: reverted
This fix has been fully reverted because it changed dataset 18 samples 6, 14, and 15 and dataset 24 sample 2 from routed outputs into solver failures. The project preference is to improve routability and DRC without turning benchmark samples into failures.
The current head has the exact same Git tree as reproduction base PR #1981:
The reproduction remains useful evidence, but this fail-loud approach should not be merged.
Revalidation
Hosted benchmarks were run sequentially with
--concurrency 1and a 2,000-second sample timeout. All eight selected samples solved and none timed out.The selected-sample DRC total is 435, compared with 505 in #1941. Because this PR's tree is identical to its reproduction base, that retained improvement belongs to the existing/base routing state, not to the reverted fail-loud patch.