Skip to content

Remove congested-port cutoff after distinct-net fix - #1907

Closed
ShiboSoftwareDev wants to merge 7 commits into
agent/repro-large-duplicate-port-prepassfrom
agent/fix-large-duplicate-port-prepass
Closed

Remove congested-port cutoff after distinct-net fix#1907
ShiboSoftwareDev wants to merge 7 commits into
agent/repro-large-duplicate-port-prepassfrom
agent/fix-large-duplicate-port-prepass

Conversation

@ShiboSoftwareDev

@ShiboSoftwareDev ShiboSoftwareDev commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pin the tiny-hypergraph root fix from Fix congested-port duplication to count distinct nets tiny-hypergraph#151
  • remove the all-or-nothing 180-connection gate and run the normal duplicate-port prepass on the full graph
  • avoid all connection sampling, obstacle metadata rewriting, and serialized net-ID remapping
  • update the focused IcePi SVG: the same single gateway changes from zero repairs to one congested source port and one visible duplicate port

The upstream fix counts distinct electrical nets per shared port instead of route segments. This matches TinyHyperGraphSolver's NetId ownership rule and prevents same-net BGA MST segments from manufacturing unnecessary topology.

Verification

  • bun test tests/features/large-graph-duplicate-port-prepass.test.ts tests/tinyhypergraph-terminal-port-ids.test.ts tests/features/preloaded-trace-graph-solver.test.ts tests/features/preloaded-fixed-segment-occupancy.test.ts
  • bunx tsc --noEmit
  • bun run build

The existing bugreport80 SVG also changes because the repaired prepass now supplies duplicate gateway ports to its pathing graph.

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
capacity-node-autorouter Ready Ready Preview Aug 4, 2026 11:38am

Request Review

@tscircuitbot

Copy link
Copy Markdown
Contributor

Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark-long [benchmark.sh args...]
/benchmark-all

Comment /benchmark to run the default dataset, or append any arguments accepted by ./benchmark.sh.
Comment /benchmark-long for an 8-vCPU run that defaults to 8 workers and has an eight-hour timeout.
Comment exactly /benchmark-all to start separate workflow runs and result comments for the default dataset plus srj18, srj19, srj20, srj21, and srj23.

Everything after /benchmark or /benchmark-long is safely forwarded to ./benchmark.sh, except --profile-solvers, which enables profile comparison tables.
Examples: /benchmark --dataset 18 --sample-timeout 2000s, /benchmark --pipeline 7 --scenario-limit 20, /benchmark all 20 --concurrency 8, and /benchmark-long --dataset 18.

Use /update-snapshots (or /us) to run BUN_UPDATE_SNAPSHOTS=1 bun test --timeout 120_000 on the PR branch and auto-commit snapshot updates.
Use /usf to read recent failed test files, update and verify their exact CI test shards, and auto-commit only their snapshots. It uses the configured fast benchmark runner by default; use /usf --ubuntu-latest for GitHub-hosted x64 CI parity.

Any PR whose title contains [BENCHMARK TEST] will automatically run one default-dataset benchmark on PR updates; it does not post a PR result comment.

…x-large-duplicate-port-prepass

# Conflicts:
#	tests/features/__snapshots__/large-graph-duplicate-port-prepass.snap.svg
#	tests/features/large-graph-duplicate-port-prepass.test.ts
@ShiboSoftwareDev ShiboSoftwareDev changed the title fix(pathing): sample congestion repair on large graphs Fix sampled duplicate-port repair without pruning topology Aug 4, 2026
…x-large-duplicate-port-prepass

# Conflicts:
#	tests/features/__snapshots__/large-graph-duplicate-port-prepass.snap.svg
#	tests/features/large-graph-duplicate-port-prepass.test.ts
@ShiboSoftwareDev ShiboSoftwareDev changed the title Fix sampled duplicate-port repair without pruning topology Remove congested-port cutoff after distinct-net fix Aug 4, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions Bot closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants