Prefer preserving caller-owned routes during rerip - #170
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The autorouter's stable-initial-assignment subclass restores fanout routes after a whole-graph rerip, but tiny-hypergraph's partial-rip optimizer had no ownership hook. It therefore reopened caller-owned fanout routes during quality optimization even though ordinary routes crossed the same hot regions.
In the SRJ29 sample003 reproduction this changed 18 preloaded fanout sections across six partial-rip rounds. Pipeline 9 later received reconstructed
through_obstacletraces and failed exact repair.Fix
Add one explicit
getRouteIdsPreferredForPreservation()hook shared by both rerip modes:Default behavior is unchanged because the base hook returns an empty set. The autorouter's existing
StableInitialAssignmentssubclass opts in for its preloaded route IDs.Result on the real reproduction
srj29 sample003, Pipeline 10, 1x effort:Tests
bun test tests/outside-in-partial-rip-tiny-hypergraph-solver.test.ts tests/selective-rerip-tiny-hyper-graph-solver.test.ts