fix: avoid 3d preview failure when OBJ cad asset is unreachable - #1540
Open
itisrohit wants to merge 6 commits into
Open
fix: avoid 3d preview failure when OBJ cad asset is unreachable#1540itisrohit wants to merge 6 commits into
itisrohit wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@itisrohit is attempting to deploy a commit to the mustafamulla29's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
You're right, the normal This PR fixes a narrower case: when a I've updated the PR title/body to reflect that narrower scope, and the regression test now targets that dual-source CAD case explicitly rather than the general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Fixes a narrower 3d preview failure case: when a
cad_componentincludes bothmodel_obj_urlandmodel_step_url, the old path preferred OBJ first.If that OBJ asset is unreachable, the preview fails instead of falling back cleanly.
Testing
bun test tests/jlcpcb-c2040-preview.test.ts