fix: obey maxMspPairDistance for nets with available net label orientations - #1078
Open
techmannih wants to merge 3 commits into
Open
fix: obey maxMspPairDistance for nets with available net label orientations#1078techmannih wants to merge 3 commits into
techmannih wants to merge 3 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
techmannih
changed the title
Member
Author
|
/us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where parallel decoupling capacitors (and other multi-pin nets with available net label orientations) formed unwanted serpentine / snake trace connections across capacitors.
LongDistancePairSolver, candidate pair generation now checksmaxMspPairDistancewhen the net hasavailableNetLabelOrientationsor is a namednetConnection.maxMspPairDistancefall back to clean net labels / power / ground symbols as designed instead of being forced into long-distance traces.tests/repros/repro-trellis-core-decoupling-snake-traces.test.tsverifying that parallel decoupling capacitors do not form adjacent traces and display clean ground labels.