Use supplier-aware PnP converter for browser fabrication exports - #5047
Open
imrishabh18 wants to merge 1 commit into
Open
Use supplier-aware PnP converter for browser fabrication exports#5047imrishabh18 wants to merge 1 commit into
imrishabh18 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
circuit-json-to-pnp-csvfrom 0.0.10 to 0.0.13 and refresh its Bun lockfile entry.exportFabricationFilesalready passessupplier: "jlcpcb"; use the converter release that consumes supplier pin-1 frames to calculate assembly rotation.This is the browser export consumer of the LED analyzer fix in tscircuit/circuit-json-util#164. Runframe does not directly depend on circuit-json-util, so its analyzer comes through core/eval.
Validation: dependency installation; RunFrame orientation-configuration test; direct CSV conversion of a supplier-reversed LED yields 180 degrees; repository-wide formatting passes.
Release coordination: after tscircuit/core#3802 and the eval dependency update are released, refresh the core/eval versions here and rebuild the standalone preview. This PR updates the placement converter only; it does not claim the browser analyzer has already been upgraded.