Skip to content

refine free-layer overlaps across copper pours - #148

Open
mohan-bee wants to merge 3 commits into
codex/rv1106-free-layer-reprofrom
codex/rv1106-free-layer-fix
Open

refine free-layer overlaps across copper pours#148
mohan-bee wants to merge 3 commits into
codex/rv1106-free-layer-reprofrom
codex/rv1106-free-layer-fix

Conversation

@mohan-bee

@mohan-bee mohan-bee commented Sep 11, 2026

Copy link
Copy Markdown

Motivation

  • Expose shared layer-transition regions across copper pours during rectangle construction, while retaining the remaining free space.

Before

  • The RV1106 repro has zero shared top/inner2 free regions across its inner1 copper pour.

After

  • Split eligible rectangle overlaps before rectsToMeshNodes assigns node IDs. Preserve remainders and reject solid obstacles, incomplete pour coverage, and overlaps too small for the configured via diameter.
  • The refreshed full-board snapshot shows 818 shared top/inner2 regions. The refinement has no custom ID generator. Rectdiff's 73 tests pass with one existing skip; type checking and build pass. RV1106 pathing completes with the local change, though its downstream routing snapshot changes.
Before After
Before After

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
rectdiff Ready Ready Preview Sep 11, 2026 7:22pm UTC

Request Review

@0hmX

0hmX commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@vreview

@vreview

vreview commented Sep 11, 2026

Copy link
Copy Markdown

Video review

Failed — the review could not finish. Tag the bot in a new comment to retry. The operator can inspect the job logs.

Reviewing commit 30ebd720.

This comment updates as work progresses.

Job: 1097193589-issue_comment-5639457823

@mohan-bee

Copy link
Copy Markdown
Author

@vreview

@vreview

vreview commented Sep 11, 2026

Copy link
Copy Markdown

Video review

Failed — the review could not finish. Tag the bot in a new comment to retry. The operator can inspect the job logs.

Reviewing commit b754d4c7.

This comment updates as work progresses.

Job: 1097193589-issue_comment-5639564593

@mohan-bee

Copy link
Copy Markdown
Author

@vreview

@vreview

vreview commented Sep 11, 2026

Copy link
Copy Markdown

Video review

Failed — the review could not finish. Tag the bot in a new comment to retry. The operator can inspect the job logs.

Reviewing commit b754d4c7.

This comment updates as work progresses.

Job: 1097193589-issue_comment-5639710397

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a solver and have a clearer graphic showing what is happening with the nodes

i don't think it is at all obvious from your screenshot what's happening, you need more graphics, probably a video, just to understand it yourself, you can then commit a simplified visualization that explains it in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants