Add pcbTracePaths support to autoroutingphase - #845
Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
28
to
108
| @@ -89,8 +99,12 @@ test("saved fanout paths reject invalid geometry and layer transitions", () => { | |||
| connection: "U1.1", | |||
| route: [wire, { ...path.route[1], from_layer: "inner1" }, path.route[2]], | |||
| }, | |||
| ]) | |||
| ]) { | |||
| expect(fanoutTracePath.safeParse(invalid).success).toBe(false) | |||
| expect( | |||
| autoroutingPhaseProps.safeParse({ pcbTracePaths: [invalid] }).success, | |||
| ).toBe(false) | |||
| } | |||
| }) | |||
Contributor
There was a problem hiding this comment.
This file contains more than one test(...) call. The style guide rule states that a *.test.ts file may have AT MOST one test(...). Here, test.each(...) (line 28) and a second test(...) (line 53) both appear in the same file. The file should be split into multiple numbered files, e.g. fanout-trace-paths1.test.ts and fanout-trace-paths2.test.ts.
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
pcbTracePathsto<autoroutingphase>so saved PCB routes are accepted by both its TypeScript interface and runtime schema. ReusesFanoutTracePathvalidation, including distance normalization and wire/via layer continuity, and regenerates the props documentation.Validation: all 512 tests pass, TypeScript typecheck passes, and changed-file formatting checks pass. Regression coverage checks saved-route preservation, unit normalization, omitted/empty paths, and invalid geometry.