fix(schSize): parse named tokens before distance - #834
Open
Flame119052 wants to merge 2 commits into
Open
Conversation
distance currently swallows xs/sm/small as NaN before the enum is tried.
circuit-json distance accepts unknown strings as NaN, so the enum never ran. Put the named sizes first so xs/sm/small/md stay tokens.
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schematicSymbolSizetrieddistancefirst.circuit-jsondistance accepts unknown strings asNaN, so"xs","sm","small", and"md"never reached the enum.Named sizes are now parsed first.
"small"and"normal"are accepted aliases. Numeric distances such as"0.5mm"still parse to millimeters.This is the props-side contract for
tscircuit/core#3108. Runtime compact-symbol selection still lives in core (companion PR).Test plan
bun test tests/schematic-size.test.ts tests/capacitor.test.ts tests/resistor.test.tsbunx tsc --noEmit