Skip to content

feat(differentialpair): add routing geometry constraints (gap, traceWidth, layer, sameLayer) - #830

Open
marcos452652258-gif wants to merge 2 commits into
tscircuit:mainfrom
marcos452652258-gif:fix/743-differential-pair-geometry
Open

feat(differentialpair): add routing geometry constraints (gap, traceWidth, layer, sameLayer)#830
marcos452652258-gif wants to merge 2 commits into
tscircuit:mainfrom
marcos452652258-gif:fix/743-differential-pair-geometry

Conversation

@marcos452652258-gif

Copy link
Copy Markdown

Summary

Fixes #743.

Adds optional routing geometry constraints to DifferentialPairProps and differentialPairProps:

  • pcbTraceWidth and alias traceWidth: explicit trace width for pair members
  • layer: target / preferred routing layer
  • pcbAllowedLayers: allowed PCB layers for routing the pair
  • sameLayer: enforce routing both pair traces on the same layer
  • matchViaTransitions: match layer via transitions between pair members

Includes unit tests in tests/differential-pair-routing-geometry.test.ts and updated generated documentation.

pinCount was declared as a bare z.number(), accepting fractional,
zero, negative, and infinite values. A fractional count produced a
header whose port count and pad count disagree, while zero/negative
counts surfaced later as an unrelated pcb_missing_footprint_error.

Validate pinCount with z.number().int().positive() so invalid values
are rejected at parse time with a message naming the prop, matching
the existing idiom in connector.ts and analogacsweepsimulation.ts.
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@marcos452652258-gif

Copy link
Copy Markdown
Author

Hi maintainers, pinging to keep this PR active — it is still tested, relevant and ready for review whenever you have time. Thank you!

@marcos452652258-gif

Copy link
Copy Markdown
Author

Still relevant — keeping active per contribution guidelines.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@marcos452652258-gif

Copy link
Copy Markdown
Author

Hi maintainers, pinging to keep this PR active — it is still tested, relevant and ready for review whenever you have time. Thank you!

@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@marcos452652258-gif

Copy link
Copy Markdown
Author

Hi maintainers, pinging to keep this PR active — it is still tested, relevant and ready for review whenever you have time. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add routing geometry constraints to DifferentialPairProps

1 participant