Use endpoint pairs as the only via span API - #99
Merged
seveibar merged 1 commit intoSep 5, 2026
Conversation
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
seveibar
merged commit Sep 5, 2026
a3c6ecc
into
fix/preserve-trace-layer-improvements
5 checks passed
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
from_layerandto_layeras the sole via span API. Remove the optional vialayersfield and its precedence path; DRC and Circuit JSON conversion derive the inclusive board-layer span from required endpoints. Reversed endpoints produce the same geometry.Replace explicit-layer tests with endpoint reversal and span-extension coverage, retaining intermediate-layer collisions, excluded layers, same-layer spans, and invalid endpoints. This is stacked on #97; merge that PR first.
Validation: all 89 tests pass (594 assertions) and typecheck passes. The autorouter consumer is updated in tscircuit/tscircuit-autorouter#2402.