Skip to content

Use endpoint pairs as the only via span API - #99

Merged
seveibar merged 1 commit into
fix/preserve-trace-layer-improvementsfrom
refactor/endpoint-only-vias
Sep 5, 2026
Merged

Use endpoint pairs as the only via span API#99
seveibar merged 1 commit into
fix/preserve-trace-layer-improvementsfrom
refactor/endpoint-only-vias

Conversation

@seveibar

@seveibar seveibar commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Use from_layer and to_layer as the sole via span API. Remove the optional via layers field and its precedence path; DRC and Circuit JSON conversion derive the inclusive board-layer span from required endpoints. Reversed endpoints produce the same geometry.

Replace explicit-layer tests with endpoint reversal and span-extension coverage, retaining intermediate-layer collisions, excluded layers, same-layer spans, and invalid endpoints. This is stacked on #97; merge that PR first.

Validation: all 89 tests pass (594 assertions) and typecheck passes. The autorouter consumer is updated in tscircuit/tscircuit-autorouter#2402.

@seveibar
seveibar requested a review from Abse2001 as a code owner September 5, 2026 16:23
@tscircuitbot

Copy link
Copy Markdown

Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark [scenario-limit|all] --dataset <drc14|srj18> --concurrency <n> --effort <n> --max-iterations <n>

Everything after /benchmark is forwarded directly to ./benchmark.sh.

Examples:

  • /benchmark -> run default SRJ18 benchmark settings
  • /benchmark 10 -> run first 10 SRJ18 samples
  • /benchmark --dataset srj18 -> run all SRJ18 samples
  • /benchmark 1 --dataset srj18 -> run the first SRJ18 sample
  • /benchmark --dataset drc14 -> run all DRC14 samples
  • /benchmark all --concurrency 4 -> run all SRJ18 samples with 4 workers
  • /benchmark --scenario-limit all --effort 2 -> run all samples with effort 2
  • /benchmark --scenario-limit 20 --max-iterations 100 -> run 20 samples with a max iteration override

Any PR whose title contains [BENCHMARK TEST] will automatically run the benchmark workflow on PR updates.

@seveibar
seveibar merged commit a3c6ecc into fix/preserve-trace-layer-improvements Sep 5, 2026
5 checks passed
@AnasSarkiz
AnasSarkiz deleted the refactor/endpoint-only-vias branch September 5, 2026 17:57
@tscircuitbot

Copy link
Copy Markdown

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants