fix: preserve polarized capacitor symbols - #562
Open
hrithik18k wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motive
Preserve the electrical meaning and original curved symbol of polarized EasyEDA capacitors during TSX conversion.
Description
C335982 uses numeric pin labels, so label-only polarity detection emitted a non-polarized capacitor with two straight plates. This change detects two-pin polarized capacitors from EasyEDA's curved plate geometry or explicit capacitor metadata, passes that semantic separately into TSX generation, and retains the existing +/− label mapping when it is available. The merged #561 reproduction now asserts
polarizedoutput and the nativecapacitor_polarized_rightsymbol, while the existing ordinary and explicitly labelled capacitor cases remain covered.Snapshot diff
Validation
bun test tests/convert-to-ts/C335982-polarized-capacitor-repro.test.ts tests/convert-to-ts/C1525-to-ts.test.ts(6 passed)bun run build