fix: reject invalid EasyEDA component detail responses - #560
Open
alexci04 wants to merge 1 commit into
Open
Conversation
alexci04
marked this pull request as ready for review
September 10, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component-details request currently checks HTTP status but ignores the JSON success flag. A response with
success: falsecan return geometry as if it succeeded; a missing result returnsundefinedwhen model metadata is disabled or produces aTypeErrorwhen enabled.This adds component-envelope validation before model metadata lookup, preserving the raw geometry for the existing conversion layer. Failures identify the requested part and include the API error code/message when available. The change follows the existing search-response validation pattern.
Validation:
06077ed); expanded coverage now includes missing/empty UUIDs.--noEmit, formatting for the three changed files,git diff --check, and the library/browser/CLI build pass.success/code/resultenvelope. The malformed responses are injected regression cases, not a claim of a live API outage.Prepared and tested with OpenAI Codex assistance. No fixed bounty or payment is claimed for this contribution.