fix: render imported MOSFET symbols with physical pin mapping - #559
Draft
MustafaMulla29 wants to merge 2 commits into
Draft
fix: render imported MOSFET symbols with physical pin mapping#559MustafaMulla29 wants to merge 2 commits into
MustafaMulla29 wants to merge 2 commits into
Conversation
MustafaMulla29
marked this pull request as draft
September 9, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Box-only EasyEDA MOSFET imports such as C501008 (STL130N6F7) now use standard MOSFET geometry through the existing
<chip symbol={...}>pattern. Physical pin numbers, aliases, footprint pads, and source/drain internal connections are preserved. Existing custom drawings and ambiguous pin layouts keep their current behavior.Channel type and mode are inferred only from explicit source metadata. When absent, the generated component requires them:
Keeps the original repro as one unconnected component. A separate test file and snapshot cover secondary-pin connections, all eight pins and the exposed drain pad, all four channel/mode variants, and missing metadata.
Validation: 17 focused tests, typecheck, and formatting pass. The previous revision passed every CI check; the test separation is being checked again.
Updated schematic snapshot