fix: emit valid JSX for footprint text with quotes and entities - #551
Open
Flame119052 wants to merge 1 commit into
Open
fix: emit valid JSX for footprint text with quotes and entities#551Flame119052 wants to merge 1 commit into
Flame119052 wants to merge 1 commit into
Conversation
JSON.stringify inside quoted JSX attributes produced invalid quotes and HTML-decoded entities. Use a JSX string expression when the value needs JS escaping or contains &.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #550.
generateFootprintTsxputJSON.stringifyinto quoted JSX attributes. That is invalid when the text contains", and it HTML-decodes&/Ainstead of keeping the original characters.Quoted attributes are kept for ordinary text (including
{NAME}). Values that need JavaScript escaping or contain&are emitted as a JSX string expression, e.g.text={"Connector 1/4\""}.Covered for silkscreen, fabrication-note, PCB-note, and dimension labels. Regression compiles the generated footprint with
runTscircuitCodeand checks the resultingtextprops.