fix: generate semiconductor load switches as six-pin chips - #547
Open
AnasSarkiz wants to merge 1 commit into
Open
fix: generate semiconductor load switches as six-pin chips#547AnasSarkiz wants to merge 1 commit into
AnasSarkiz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #545; review and land the before snapshot PR first.
Exclude power-distribution, load, high-side and low-side semiconductor switch categories from the mechanical-switch matcher, including space/hyphen variants. TPS22918DBVR now uses
<chip>andChipProps, retaining VIN/GND/ON/CT/QOD/VOUT and the exact supplier footprint/courtyard snapshot. It follows the existing chip naming convention instead of forcingSW1; callers can supply the IC reference throughname.Updated generated-source, classification, schematic and PCB snapshots show the change. The rendered component has six source ports and zero internal connections. Existing slide/toggle/DIP/pushbutton classification is preserved, and nested metadata/category-field regressions are included.
Validation: 8 focused tests, 3 text snapshots and schematic/PCB snapshots pass; typecheck, formatting and build pass. The full local run had 217 passes, two existing CAD-test timeouts and one associated asynchronous 3D timeout error. C2943786 passed an isolated recheck; C9900017879 still hit its 10-second limit on this branch (it passed on the DDR branch). Both fixes also pass together: 28 focused tests, 14 text snapshots, schematic/PCB snapshots and typecheck. Repository CI currently targets PRs based on
main, so this stacked base does not trigger those workflows until retargeted.This selects the appropriate imported component type; it does not add a behavioral load-switch simulation.