fix: preserve terminals on multi-pin switch imports - #541
Open
GokulPandi-M wants to merge 6 commits into
Open
Conversation
GokulPandi-M
marked this pull request as ready for review
September 4, 2026 11:17
techmannih
reviewed
Sep 5, 2026
techmannih
left a comment
Member
There was a problem hiding this comment.
dont forgot to add reference?
techmannih
reviewed
Sep 5, 2026
GokulPandi-M
marked this pull request as draft
September 5, 2026 07:24
GokulPandi-M
marked this pull request as ready for review
September 5, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While using C2941005 on a real board, I found that the converter treated the six-terminal slide switch as a two-terminal SPST switch. This removed pins 3–6 from the schematic. Repro: #538.
Change
{REF}placeholder, so names such asSW1andSW2are generated dynamically.The converter intentionally does not infer SPDT/DPDT topology from pin count alone. For C2941005, the manufacturer drawing uses pins 2 and 5 as the common terminals, while the built-in DPDT symbol uses a different pin topology. Keeping the imported symbol avoids silently changing electrical meaning.
References: JLCPCB C2941005
Ref:
Verification
This PR does not change PCB, 3D-model handling, or add native switch simulation semantics for multi-terminal imports.