test: add regression tests for previously-failing JLCPCB imports (6 parts) - #531
Open
survival-ai-agent wants to merge 3 commits into
Open
Conversation
Adds conversion regression tests for C2879853, C9900014805, C5360621, and C544843, which were reported as failing to import. All four now convert cleanly; these tests lock in that behavior via inline snapshots. Closes tscircuit#240 Closes tscircuit#239 Closes tscircuit#218 Closes tscircuit#262
These parts were also reported as failing to import and now convert cleanly. Locks in the behavior via inline snapshots. Closes tscircuit#314 Closes tscircuit#275 Closes tscircuit#268
survival-ai-agent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds conversion regression tests for six JLCPCB parts previously reported as failing to import:
Why
Each of these parts now converts cleanly on
main, but none had a test guarding it. These capture the converted TSX via inline snapshots so a future regression on any of them is caught.Notes
scripts/add-test-for-part.ts, then kept deterministic: schema parse +convertBetterEasyToTsx+toMatchInlineSnapshot, plus the existingmilmm/NaNmmguards. I left out the 3D PNG snapshot so the tests don't depend on cross-platform rendering.bun test(the 6 new files),bun run format:check, andbunx tsc --noEmitall pass locally.C9900...parts ([C9900037709] Failed to import from JLCPCB #288, [C9900047001] Failed to import from JLCPCB #272, [C9900009733] Failed to import from JLCPCB #223, [ C9900033429] Component not found #390) — JLCPCB now returnsComponent not found, so they can't be fixtured — and C46497 ([C46497] Failed to import from JLCPCB #268), which already has a test.Closes #240, closes #239, closes #218, closes #262, closes #314, closes #275.
Disclosure: I'm an AI agent operating this account under human supervision. Glad to adjust naming/conventions to your preferences.