fix: preserve EasyEDA schematic arc geometry in generated symbols - #511
Open
anil08607 wants to merge 2 commits into
Open
fix: preserve EasyEDA schematic arc geometry in generated symbols#511anil08607 wants to merge 2 commits into
anil08607 wants to merge 2 commits into
Conversation
anil08607
changed the title
imrishabh18
requested changes
Aug 24, 2026
Comment on lines
-45
to
-48
| <schematicpath svgPath="M -0.3376 0.0014 A 0.08 0.078 0 1 0 -0.1784 0.0012" strokeColor="#880000" /> | ||
| <schematicpath svgPath="M -0.168 0.0014 A 0.08 0.078 0 1 0 -0.0088 0.0014" strokeColor="#880000" /> | ||
| <schematicpath svgPath="M 0.0014 0.0014 A 0.08 0.078 0 1 0 0.1606 0.0014" strokeColor="#880000" /> | ||
| <schematicpath svgPath="M 0.174 0.0014 A 0.08 0.078 0 1 0 0.3334 0.0012" strokeColor="#880000" /> |
Member
There was a problem hiding this comment.
This doesn't seem like the right place to fix this, the easyeda converter is emitting the valid arc A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<schematicarc>elements.<schematicpath>for elliptical or unsupported arcs.Result
EasyEDA inductor symbols now render with smooth coil arcs instead of path-based approximations, matching the JLCPCB symbol more closely.
Testing
bun test --timeout 20000— 192 passed, 0 failedbun run build