Fix missing refdes and thick strokes in custom symbols - #496
Open
seveibar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
The JLCPCB imports for fuse C354900 and MOV C1527439 emit custom symbol elements. Custom symbols do not receive the automatic chip-box designator, so their names were absent. Their EasyEDA rectangle line width was also omitted, causing tscircuit to use its 0.12 default instead of the imported 1 x 0.02 = 0.02 width.
The regression test renders both parts with realistic F1 and RV1 names and verifies the resolved schematic text and 0.02 rectangle stroke. Existing custom-symbol snapshots are refreshed to document the general behavior.
Verification