Preserve courtyard RECT geometry in generated TSX - #494
Open
rushabhcodes wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a data-preservation and geometry-type regression in EasyEDA footprint conversion: explicit courtyard-layer RECT elements were not preserved as courtyard rectangles in generated TSX.
Impact
Affected footprints could lose their rectangular courtyard keepout geometry or receive an extra synthetic courtyard outline when converted. The source payload contains an explicit courtyard RECT, but the conversion path previously relied on the BBox courtyard-outline fallback whenever no courtyard TRACK was present.
Root cause
generateFootprintTsxhandled courtyard outlines but omittedpcb_courtyard_rectelements.Fix
pcb_courtyard_rectas<courtyardrect>.<courtyardoutline>when an explicit courtyard RECT exists.Regression coverage
The package RECT conversion test moves a RECT onto EasyEDA courtyard layer 13 and verifies:
pcb_courtyard_rectis produced;pcb_courtyard_outlineis added;<courtyardrect>and no<courtyardoutline>.The existing footprint-generator test remains focused on standalone oval-hole generation; courtyard rectangles are covered at the conversion boundary where the geometry type is selected.
Validation
bun test tests/convert-package-rect.test.ts tests/generate-footprint-tsx.test.tsbun run build