fix(billing): require card-backed trial again#56
Merged
Conversation
Revert the no-card signup trial flow so access depends on a Stripe subscription trial started at checkout, preventing app access before a payment method is collected. Co-authored-by: Cursor <cursoragent@cursor.com>
Show the checkout-based trial duration again on the subscribe page and rename the signup billing test file so it matches the current no-trial-at-signup behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Add a trypost config toggle to switch between card-required checkout trials and no-card signup trials, and wire signup, checkout, access gating, UI copy, and tests to both modes. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the trial card requirement switch as a plain boolean in config/trypost.php so changing the app flow is a single in-repo config edit without env wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
Increase the default trial duration from 7 to 8 days in the cashier configuration to better align with user feedback and improve trial experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trialDayson subscribe and->trialDays(...)in billing checkoutTest plan
vendor/bin/pint --dirty --format agentphp artisan test --compact tests/Feature/Auth/TrialOnSignupTest.php tests/Feature/Middleware/TrialMiddlewareAccessTest.php tests/Feature/BillingControllerTest.php tests/Unit/Models/AccountTest.phpMade with Cursor