Skip to content

last value of ConfigEntries for topic is used for all entries, single variable in for loop #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

last value of ConfigEntries for topic is used for all entries, single variable in for loop #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058f8b1
Fix bug that no more than ConfigEntries per topic can be defined
nirfri Oct 14, 2023
79897ce
Update kafka_admin.go
nirfri Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion admin/kafka_admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ func (c *kafkaAdmin) CreateTopics(topics map[string]*Topic) error {
}
details.ConfigEntries = map[string]*string{}
for cName, config := range info.ConfigEntries {
details.ConfigEntries[cName] = &config
configCpy := config
details.ConfigEntries[cName] = &configCpy
}

err := c.admin.CreateTopic(name, details, false)
Expand Down