Simplify for custom ISO usage #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-trycua
reviewed
Nov 13, 2025
compose.yml
Outdated
| volumes: | ||
| - ${STORAGE}:/storage | ||
|
|
||
| prepare-golden-image: |
Author
There was a problem hiding this comment.
The prepare-golden-image service is for creating the golden Windows image from the ISO. You run it once with docker compose --profile prepare-golden-image up to build the image, then use the regular service to boot from it.
Please refer the usage section in readme: https://github.com/trycua/windows-local/blob/8c93722be46d43d7c5794f5b9c0268e1ddb37812/readme.md#via-docker-compose
Author
There was a problem hiding this comment.
This does not work. I have made two separate compose files - see this commit: e241426
f-trycua
reviewed
Nov 13, 2025
| -p 8006:8006 \ | ||
| --device=/dev/kvm \ | ||
| --cap-add NET_ADMIN \ | ||
| --mount type=bind,source=./custom.iso,target=/custom.iso \ |
There was a problem hiding this comment.
did you make sure subsequent run don't need the custom.iso attached, and you can instead mount the storage?
f-trycua
reviewed
Nov 13, 2025
- Split compose.yml into two files: compose.yml for running and compose.prepare.yml for golden image preparation - Rename env vars STORAGE->STORAGE_DIR and ISO->ISO_FILE to avoid conflicts with internal script variables - Remove unused VERSION env var (hardcoded in scripts) - Update README with new command syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed Features
mido.sh) - No longer needed as users provide their own custom ISOskubernetes.ymlas this fork targets Docker/Docker Compose onlyUpdated Components
windowsservice for running pre-built golden imagesprepare-golden-imageprofile for creating golden images from custom ISOsTesting