-
-
Notifications
You must be signed in to change notification settings - Fork 26
add file watching capability to runtime execution #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Performance Comparison
|
load1n9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can fix those CI issues before merging though
load1n9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merging can you fix these 2 lint issues real quick
error: the Err-variant returned from this function is very large
--> cli/src/run.rs:42:6
|
42 | ) -> Result<()> {
| ^^^^^^^^^^
|
::: cli/src/error.rs:45:5
|
45 | / ParseError {
46 | | diagnostics: Vec,
47 | | file_path: String,
48 | | #[source_code]
49 | | source_code: NamedSource,
50 | | error_spans: Vecmiette::SourceSpan,
51 | | },
| |- the variant ParseError contains at least 144 bytes
...
59 | / RuntimeError {
60 | | message: String,
61 | | file_path: Option,
62 | | line: Option,
... |
67 | | error_span: Option,
68 | | },
| |- the largest variant contains at least 160 bytes
|
= help: try reducing the size of error::AndromedaError, for example by boxing large elements or replacing it with Box<error::AndromedaError>
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: -D clippy::result-large-err implied by -D warnings
= help: to override -D warnings add #[allow(clippy::result_large_err)]
error: this loop could be written as a while let loop
--> cli/src/run.rs:55:5
|
55 | / loop {
56 | | // Wait for the first event (blocking)
57 | | match rx.recv() {
58 | | Ok(_event) => {
... |
70 | | }
| |_____^ help: try: while let Ok(_event) = rx.recv() { .. }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
= note: -D clippy::while-let-loop implied by -D warnings
= help: to override -D warnings add #[allow(clippy::while_let_loop)]
fix #181