Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trulens hotspots #1757

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-fgralinski
Copy link

@sfc-gh-fgralinski sfc-gh-fgralinski commented Jan 29, 2025

Description

Add TruLens Hotspots

Other details good to know for developers

Please include any other details of this change useful for TruLens developers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 29, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,203 @@
{
Copy link
Contributor

@sfc-gh-jreini sfc-gh-jreini Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #24.                    model="gpt-4-turbo",

nit, please sub for gpt-4o or gpt-4o-mini


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Though it was copied from summarization.ipynb (where it's still gpt-4-turbo).

@@ -0,0 +1,555 @@
{
Copy link
Contributor

@sfc-gh-jreini sfc-gh-jreini Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we align this more with a LLM chat/Q&A example instead of this prediction task?


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking about that, the problem is that we need is (1) dataset on an open license, without any copyright issues (and, for instance, HotspotsQA is CC-BY-SA 4.0), (2) with per-sample evaluation scores.

examples/quickstart/hotspots.ipynb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants