[wip] session: impl database session #539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
===================================================
- Coverage 74.83858% 74.81446% -0.02412%
===================================================
Files 195 201 +6
Lines 29891 31260 +1369
===================================================
+ Hits 22370 23387 +1017
- Misses 6339 6734 +395
+ Partials 1182 1139 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nomand-zc
reviewed
Oct 23, 2025
| "time" | ||
|
|
||
| "gorm.io/driver/mysql" | ||
| "gorm.io/gorm" |
There was a problem hiding this comment.
这里用gorm是不是有点重了。 可以考虑用内置的包?
There was a problem hiding this comment.
主要是期望能直接适配pg、mysql、clickhouse
Rememorio
reviewed
Oct 23, 2025
| // | ||
|
|
||
| // Package database provides the Database instance info management. | ||
| package database |
nomand-zc
reviewed
Oct 24, 2025
| key.AppName, key.UserID, key.SessionID). | ||
| Order("timestamp ASC"). | ||
| Limit(int(count - int64(s.opts.sessionEventLimit))). | ||
| Delete(&sessionEventModel{}).Error; err != nil { |
There was a problem hiding this comment.
这里要不要考虑增加一个软删除的配置， 获取的时候加过期条件判断。如果配置了软删除选项，这里就别Delete了。 业务这边应该也有希望保留全部历史Events的诉求， 用于做一些事后的分析，效果评估的素材之类的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.