agent: resolve agent card by a2a.Client #511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyprh
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
===================================================
- Coverage 78.13849% 78.12094% -0.01755%
===================================================
Files 195 196 +1
Lines 29879 29983 +104
===================================================
+ Hits 23347 23423 +76
- Misses 5398 5420 +22
- Partials 1134 1140 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hyprh
changed the title
|
Ageng-》 |
hyprh
changed the title
done，可以先过一下这个 https://github.com/trpc-group/trpc-a2a-go/pull/96，需要先合并这个 |
WineChord
requested changes
Oct 23, 2025
server/a2a/server.go
Outdated
| } | ||
|
|
||
| if options.host == "" { | ||
| return nil, errors.New("host is required") |
There was a problem hiding this comment.
如果已经有 agent card，这里对 host 的检查是否过于严格？
agent/a2aagent/a2a_agent.go
Outdated
| return nil, fmt.Errorf("failed to resolve agent card: %w", err) | ||
| } | ||
| agent.agentCard = agentCard | ||
| // Determine the agent URL and normalize it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on trpc-group/trpc-a2a-go#96